fix: reliability fixes and prepare v1.0.2 - #161
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
https://github.com/ddv1982/echo/blob/65e4bf57368930ab7905394c1a5ed0202221b5e0/crates/echo/src/audiolk/audio.rs#L1016-L1017
When load_wav processes a WAV whose header declares an unusually large sample rate relatively prime to 16 kHz, this alignment grows roughly to twice that rate; for example, a tiny file declaring 50,000,003 Hz requests an input buffer of about 100 million f32s. The previous implementation used memory proportional to the decoded/output samples, whereas this can now OOM or panic while transcribing an otherwise small malformed or unusual WAV. Reject unsupported source rates or choose a bounded block size that does not scale with the full reduced-rate denominator.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Addressed the sample-rate allocation finding: source rates outside 1..=384000 Hz now return AudioError::Unsupported. WAV headers are checked before decoding; capture configuration is checked before buffer allocation; the public conversion API is fallible and all callers propagate errors. Added a 50,000,003 Hz / 3,126-frame WAV regression plus upper-bound and capture-path checks. All 23 audio tests and workspace/all-target clippy pass. @codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26032a1e88
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Changes
Verification
Release operations
Merge only after CI and review are clear; tag v1.0.2 only after main package gates pass. APT publication now needs workflow write access to the apt-publication-state branch. Existing signed sites bootstrap state automatically. No live deployment or real-model transcription was performed locally.