fix: distinguish temporary homes in qualification evidence - #63
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6487edf8b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const paths = text.replace(/\\+\//g, "/"); | ||
| if ( | ||
| /(?:\/Users\/[^/\s]+|\/home\/[^/\s]+|[A-Za-z]:\\Users\\[^\\\s]+)/.test(text) | ||
| /(?:(?:^|[\s"'`=():,;<>[\]{}!?|]|\\[nrtbf]|file:\/\/[^/\s"'<>]*)[*_~]*\/+(?:Users|home)\/[^/\s]+|[A-Za-z]:\\+Users\\+[^\\\s]+)/.test( |
There was a problem hiding this comment.
When a transcript or tar member contains colorized terminal output such as \u001b[31m/home/alice/private.txt, the ANSI sequence's final m immediately precedes the path and is not an accepted boundary, so this regex does not reject the private absolute path. The previous substring-based guard caught this case, and tool output can realistically contain ANSI formatting, allowing a user-home path to be sealed into qualification evidence.
Useful? React with 👍 / 👎.
2 participants
Summary
Validation
No generated evidence, credentials, version changes or publication are included.