test: align eval host startup and cleanup deadlines - #64
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d32cad61f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| files: { "package.json": '{"name":"eval-host-config-test"}\n' }, | ||
| reviewer: { model: "provider/reviewer", steps: 80 }, | ||
| // Let startup own cancellation/cleanup before the outer test expires. | ||
| signal: AbortSignal.timeout(180_000), |
There was a problem hiding this comment.
Preserve the host's full startup window
On a slow filesystem, this signal can cancel an otherwise valid startup early: its 180-second clock begins when EvalHost.start is invoked, but the harness does not begin its own STARTUP_TIMEOUT_MS deadline until after credential copying, fixture creation, synchronous Git commands, package-cache copying, and process spawning. Consequently, that setup time is subtracted from the host's intended 180-second health/readiness allowance, making this integration test flaky in environments where startup legitimately approaches the internal deadline; give the cancellation signal additional headroom while keeping it below the 240-second outer timeout.
Useful? React with 👍 / 👎.
Summary
Validation
This PR does not claim release qualification or authorize publication.