Skip to content

[deckhouse-cli] Updating the debug archive and adding an archive for virtualization #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VaLosev wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[deckhouse-cli] Updating the debug archive and adding an archive for virtualization #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e6c884d
Update debug archive v1
VaLosev Aug 28, 2026
f4924db
Update debug archive v2
VaLosev Sep 1, 2026
e92fd71
Update debug archive v3
VaLosev Sep 1, 2026
1071427
Update debug archive v4
VaLosev Sep 1, 2026
214e8c6
Update debug archive v5
VaLosev Sep 7, 2026
03e640d
Update debug archive v6
VaLosev Sep 8, 2026
554fee2
Update debug archive v7
VaLosev Sep 8, 2026
41cbf32
Update debug archive v8
VaLosev Sep 8, 2026
6b88484
Update debug archive v9
VaLosev Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/system/cmd/collect-debug-info/collect-debug-info.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import (
"k8s.io/kubectl/pkg/util/templates"

"github.com/deckhouse/deckhouse-cli/internal/system/cmd/collect-debug-info/debugtar"
"github.com/deckhouse/deckhouse-cli/internal/system/cmd/collect-debug-info/virtualizationtar"
"github.com/deckhouse/deckhouse-cli/internal/utilk8s"
)

Expand Down Expand Up @@ -79,6 +80,8 @@ func NewCommand() *cobra.Command {
collectDebugInfoCmd.Flags().DurationVar(&commandTimeout, "command-timeout", 2*time.Minute, "Timeout for each individual debug command execution")
collectDebugInfoCmd.Flags().DurationVar(&requestInterval, "request-interval", 0, "Minimum interval between debug command executions to avoid overloading the cluster (e.g. 200ms, 500ms, 1s). Zero disables rate limiting (default 0s)")

collectDebugInfoCmd.AddCommand(virtualizationtar.NewCommand())

@ldmonster ldmonster Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First subcommand added, but Args is still nil — a typo silently runs the full archive

Affected lines: internal/system/cmd/collect-debug-info/collect-debug-info.go 56-77 (command literal with no Args:) + 83 (AddCommand)

collectDebugInfoCmd has a RunE and no Args:. Traced through cobra v1.10.2:

  1. Find -> innerfind descends to collect-debug-info; findNext("virtualisation") misses, so it returns this command with args ["virtualisation"].
  2. legacyArgs (args.go): if !cmd.HasSubCommands() { return nil } no longer short-circuits, but the unknown-command branch is guarded by !cmd.HasParent() — and this command has a parent (system) — so it returns nil. The "unknown command" error is root-only.
  3. ValidateArgs: if c.Args == nil { return ArbitraryArgs(...) } -> nil.
  4. RunE: func(cmd *cobra.Command, _ []string) discards the positional arg.

So d8 system collect-debug-info virtualisation > vm.tar.gz runs the full ~63-command cluster-wide collection into vm.tar.gz, exit 0, no "Did you mean" suggestion — after a long wait, and not the archive the user asked for.

Suggested change
collectDebugInfoCmd.AddCommand(virtualizationtar.NewCommand())
collectDebugInfoCmd.Args = cobra.NoArgs
collectDebugInfoCmd.AddCommand(virtualizationtar.NewCommand())

(Worth setting Args: cobra.NoArgs on the new virtualization command too.)


Comment thread
VaLosev marked this conversation as resolved.
return collectDebugInfoCmd
}

Expand Down
Loading
Loading