Skip to content

change third party scope_exit to std::experimental #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gshigin wants to merge 2 commits into
base: pp
Choose a base branch
from
Open

change third party scope_exit to std::experimental #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
585fcae
change third party scope_exit to std::experimental
gshigin Jul 29, 2026
85c92ad
formatter fix
gshigin Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pp/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ cc_library(
"//third_party",
"@lz4",
"@parallel_hashmap",
"@scope_exit",
"@xxHash",
"@roaring",
],
Expand Down
1 change: 0 additions & 1 deletion pp/MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ use_repo(
"quasis_crypto",
"re2",
"roaring",
"scope_exit",
"simdutf",
"snappy",
"xxHash",
Expand Down
2 changes: 1 addition & 1 deletion pp/bare_bones/bit_sequence.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include <arm_acle.h>
#endif

#include <scope_exit.h>
#include <experimental/scope>
#include <span>

#include "bit.h"
Expand Down
2 changes: 1 addition & 1 deletion pp/bare_bones/crc32.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#include <arm_acle.h>
#endif

#include <scope_exit.h>
#include <experimental/scope>

#include "bare_bones/exception.h"
#include "bare_bones/streams.h"
Expand Down
2 changes: 1 addition & 1 deletion pp/bare_bones/encoding.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#include <type_traits>
#include <utility>

#include <scope_exit.h>
#include <experimental/scope>

#include "bit_sequence.h"
#include "exception.h"
Expand Down
4 changes: 2 additions & 2 deletions pp/bare_bones/serializer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#include <fstream>
#include <span>

#include <scope_exit.h>
#include <experimental/scope>

#include "exception.h"

Expand Down Expand Up @@ -49,4 +49,4 @@ void deserialize(std::istream& stream, Vector& vector) {
}
}

} // namespace BareBones
} // namespace BareBones
2 changes: 1 addition & 1 deletion pp/bare_bones/snug_composite.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#include <parallel_hashmap/phmap.h>
#pragma GCC diagnostic pop

#include <scope_exit.h>
#include <experimental/scope>

#include <concepts>
#include <cstdint>
Expand Down
2 changes: 1 addition & 1 deletion pp/bare_bones/stream_v_byte.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#include <cstddef>
#include <utility>

#include <scope_exit.h>
#include <experimental/scope>

#include "bare_bones/iterator.h"
#include "exception.h"
Expand Down
2 changes: 1 addition & 1 deletion pp/bare_bones/vector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#include <fstream>
#include <numeric>

#include <scope_exit.h>
#include <experimental/scope>

#include "allocated_memory.h"
#include "exception.h"
Expand Down
2 changes: 1 addition & 1 deletion pp/primitives/snug_composites_filaments.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#pragma once

#include <scope_exit.h>
#include <cstring>
#include <experimental/scope>
#include <iterator>

#include "bare_bones/exception.h"
Expand Down
5 changes: 1 addition & 4 deletions pp/third_party/cedar.BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,5 @@ cc_library(
name = "cedar",
hdrs = ["cedar.h", "cedarpp.h"],
include_prefix = "cedar",
deps = [
"@scope_exit",
],
visibility = ["//visibility:public"],
)
)
8 changes: 0 additions & 8 deletions pp/third_party/deps.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,6 @@ def _third_party_deps_impl(_ctx):
url = "https://github.com/greg7mdp/parallel-hashmap/archive/refs/tags/1.35.zip",
)

http_archive(
name = "scope_exit",
build_file = Label("//third_party:scope_exit.BUILD"),
sha256 = "9428fcdf00714e25fc7c67c28faf0821787b3234165b542a7f2223f464747d83",
strip_prefix = "SC22WG21_Papers-7f9c58dabea6872f86f7960157e2ca38880e14cb/workspace/P0052_scope_exit/src",
url = "https://github.com/PeterSommerlad/SC22WG21_Papers/archive/7f9c58dabea6872f86f7960157e2ca38880e14cb.zip",
)

http_archive(
name = "lz4",
build_file = Label("//third_party:lz4.BUILD"),
Expand Down
2 changes: 1 addition & 1 deletion pp/third_party/patches/cedar/0001-cedarpp.h.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
+#include <ios>
+#include <string>
+
+#include <scope_exit.h>
+#include <experimental/scope>

#ifdef HAVE_CONFIG_H
#include "config.h"
Expand Down
11 changes: 0 additions & 11 deletions pp/third_party/scope_exit.BUILD
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion pp/wal/wal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#pragma once

#include <scope_exit.h>
#include <chrono>
#include <experimental/scope>
#include <iterator>
#include <limits>
#include <ranges>
Expand Down
Loading