Conversation
Alan-Paul
force-pushed
the
fix/oncall-group-collaboration
branch
from
September 17, 2026 08:05
05e385e to
7f59f3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
启用 XPI 时,自动入群创建的 Oncall 会话把其他有权限成员的补充当作跨发送者打断,要求原发起者逐条确认;关闭 XPI 时,补充又可能直接进入当前回合,不能保证逐条执行。确认卡片又可能把 mention ID 中的下划线转义,发送失败后原消息被移出待确认队列。此 PR 让自动开工的 Oncall 群保留真实发送者,按回合顺序接收补充;确认发送失败时保留原消息并重试。
本 PR 从 #1394 拆出,已同步
master(74c303d9e),可独立合入;不包含 Codex 启动门控或延迟 committed 的改动。行为
queueAfterActiveTurn;worker 在上一回合终止前不写入 CLI、不替换身份、不合并输入,也不清除当前 TUI 问题。xpiSharedCwd*协调字段,不恢复旧类型。flowchart TD A[有权限成员的消息] --> B{自动开工的 Oncall 会话} B -->|是| C[保留真实发送者并排队] C --> D[上一回合结束且 CLI 就绪] D --> E[按顺序提交下一条] B -->|否| F{主干 XPI 开关} F -->|关闭| J[普通投递] F -->|开启| G{确认卡片发送结果} G -->|失败| H[保留原消息并退避重试] G -->|送达| I[等待明确选择或真实超时]影响范围与验证边界
集成覆盖上述具体组合,未对所有 CLI × 后端宣称端到端验证。
验证
bun run build通过;10 个相关测试文件共 173 项通过;Bun 下真实 worker 的 XPI 开/关两组回归 2/2 通过。05e385ef2的 CI 35092362021 9/9 全部通过,含 Node 三个分片及汇总、Bun 全套、build 和三个平台二进制检查。09-17 复核
当前没有新增评审评论,旧提交 CI 为 9/9。已 rebase 到
74c303d9e并解决src/types.ts的消息类型冲突:同时保留queueAfterActiveTurn和主干新增的readonlyContinuation;其余改动经 range-diff 核对保持一致。新提交
7f59f3ea8的 5 个相关测试文件 113/113 通过,包含真实 worker 的 XPI 开/关两组协作场景;tsc --noEmit -p tsconfig.json通过。新一轮 CI 35197875707 9/9 全部通过,Bun 日志确认 1167/1167 files green, 0 failing。