Repository navigation
Stop hidden wall examples from mounting below their breakpoints - #63
Open
Floating-Y wants to merge 1 commit into
Open
Floating-Y wants to merge 1 commit into
Floating-Y wants to merge 1 commit into
Conversation
Signed-off-by: danwood <118035379+Floating-Y@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Below
md, the wall still mounted 14 examples in CSS-hidden columns. Their initialization and effects continued, including the elapsed timer inRun → TurnStatus → useElapsed. This affected both the home page and Create preview 02.What changes
48rem,64remand1400px. Keep the first column, CSS classes, example order andfullbehavior.useMediaQueryand read its initial match synchronously, so the first desktop commit already has the correct columns. Keep its existing change subscription and cleanup.scripts/check-wall.html, a browser behavior check using real iframe viewports, React and native timers; no new dependencies.Tradeoff: narrowing the window unmounts the affected columns. Widening it again remounts them with fresh local demo state, including form values and elapsed clocks. No state persistence is added; the first column stays mounted.
How it was checked
fullvalues, and the first desktop commit./create?welcome=0preview 02 at 390px and 1600px in dark and light themes; checked the open team menu and theme switching.drawer-dialogcaller at 390px and 1600px in both themes, including the open Drawer and Dialog./dev/examples: 389/389 mounted, 0 failed in each theme.npm ci,node --test scripts/block-metadata.test.mjs(8 passed),npm run docs,npm run typecheckandnpm run buildpassed. The generated registry matched the committed registry;git diff --exit-code registry.jsonandgit diff --checkpassed.Windows Node 22.15.0 also passed installation, the eight metadata tests and type checking. Native
npm run docsandnpm run buildstop at the existing CRLF heading parser error inscripts/build-docs.mjs:141. The Linux validation used a temporary copy with MDX checkout line endings normalized to LF; no documentation tooling changes are included.Before review
git commit -s)/dev/examplesreports0 failed