Repository navigation
fix: correct optimization status and pulse verification - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GRAPE could report a failed line search as convergence, and MCP pulse verification checked only nominal B1 even when the design requested an RF-power ensemble. Seedless also accepted phase arrays whose length disagreed with the declared pulse duration.
line_search_failedwithconverged=Falsewhen the search finds no positive step.xycite.Validation: full native suite 274 passed; targeted NumPy fallback suite 132 passed; Ruff, strict mypy, Clippy with warnings denied, and
git diff --checkpassed. Regression tests first reproduced the failures, including B1 extrema, mismatched phase length, and quadratic prefix work.After rebuilding the native extension for the Rust lint compatibility change, the Bloch, Seedless, Rust accelerator, and MCP tests passed (46 tests). Independent code review found no blockers.