Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/optimizer_config.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -1242,7 +1242,7 @@
},
"seed": {
"default": 42,
"exclusiveMinimum": 0,
"minimum": 0,
"title": "Seed",
"type": "integer"
}
Expand Down
4 changes: 2 additions & 2 deletions src/autointent/_optimization_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from typing import TYPE_CHECKING, Any

from pydantic import BaseModel, Field, PositiveInt, field_validator
from pydantic import BaseModel, Field, NonNegativeInt, field_validator

from .configs import (
CrossEncoderConfig,
Expand Down Expand Up @@ -49,7 +49,7 @@ def validate_embedder_config(cls, v: Any) -> EmbedderConfig: # noqa: ANN401

hpo_config: HPOConfig = HPOConfig()

seed: PositiveInt = 42
seed: NonNegativeInt = 42

@classmethod
def from_preset(cls, preset: SearchSpacePreset) -> OptimizationConfig:
Expand Down
25 changes: 24 additions & 1 deletion tests/configs/test_full_config.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import pytest
from pydantic import ValidationError

from autointent import OptimizationConfig
from autointent import OptimizationConfig, Pipeline
from tests.conftest import load_optimization_config


Expand All @@ -17,3 +17,26 @@ def test_not_valid_reporting() -> None:

with pytest.raises(ValidationError):
OptimizationConfig(**config)


@pytest.mark.parametrize("seed", [0, 42])
def test_non_negative_seed(seed: int) -> None:
config = OptimizationConfig(seed=seed, search_space=[])
assert config.seed == seed


def test_negative_seed_is_rejected() -> None:
with pytest.raises(ValidationError, match="seed"):
OptimizationConfig(seed=-1, search_space=[])


def test_pipeline_from_preset_accepts_zero_seed() -> None:
pipeline = Pipeline.from_preset("classic-light", seed=0)
assert pipeline._seed == 0


def test_pipeline_from_optimization_config_accepts_zero_seed() -> None:
config = load_optimization_config("full_training")
config["seed"] = 0
pipeline = Pipeline.from_optimization_config(config)
assert pipeline._seed == 0