Skip to content

fix: allow seed=0 in OptimizationConfig #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kayaal34 wants to merge 1 commit into from
Closed

fix: allow seed=0 in OptimizationConfig #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/optimizer_config.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1242,7 +1242,7 @@
},
"seed": {
"default": 42,
"exclusiveMinimum": 0,
"minimum": 0,
"title": "Seed",
"type": "integer"
}
Expand Down
4 changes: 2 additions & 2 deletions src/autointent/_optimization_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from typing import TYPE_CHECKING, Any

from pydantic import BaseModel, Field, PositiveInt, field_validator
from pydantic import BaseModel, Field, NonNegativeInt, field_validator

from .configs import (
CrossEncoderConfig,
Expand Down Expand Up @@ -49,7 +49,7 @@ def validate_embedder_config(cls, v: Any) -> EmbedderConfig: # noqa: ANN401

hpo_config: HPOConfig = HPOConfig()

seed: PositiveInt = 42
seed: NonNegativeInt = 42

@classmethod
def from_preset(cls, preset: SearchSpacePreset) -> OptimizationConfig:
Expand Down
11 changes: 11 additions & 0 deletions tests/configs/test_full_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,14 @@ def test_not_valid_reporting() -> None:

with pytest.raises(ValidationError):
OptimizationConfig(**config)


@pytest.mark.parametrize("seed", [0, 1, 42])
def test_seed_accepts_non_negative(seed: int) -> None:
config = OptimizationConfig(seed=seed, search_space=[])
assert config.seed == seed


def test_seed_rejects_negative() -> None:
with pytest.raises(ValidationError):
OptimizationConfig(seed=-1, search_space=[])