Skip to content

fix(compat): distinguish auto and dontAsk permission pills - #367

Merged
delexw merged 1 commit into
delexw:mainfrom
monsterlag:fix/issue-346-d0aa
Oct 23, 2026
Merged

delexw merged 1 commit into
delexw:mainfrom
monsterlag:fix/issue-346-d0aa

Conversation

@monsterlag

Copy link
Copy Markdown
Contributor

Note

AI-generated, not reviewed by a human. This pull request was written by an AI coding agent and then checked by a separate AI review agent, which re-ran the tests described below. No human has reviewed the code. It is submitted by @monsterlag, who runs these agents. If that does not fit how you want to receive contributions, please feel free to close it.

Summary

auto and dontAsk fell through to the generic InfoBar pill style, and dontAsk displayed as a raw camelCase value.

  • Give auto a blue pill and dontAsk an orange pill labelled don't ask, using existing theme colours and contrasting dark text.
  • Keep default/manual pills hidden and preserve the unknown-mode fallback.
  • Add regression coverage for mode labels/classes and document the mapping in the frontend spec.

Fixes #346.

Testing

  • Before the fix, the targeted Vitest run failed with 3 failures covering the missing mode styling and readable label. After the fix, all 139 targeted tests passed.
  • npm run check passed: both TypeScript checks, lint, formatting, Rust clippy/formatting, 667 frontend tests, 946 Rust unit tests and 4 Rust integration tests. Oxlint reports two existing warnings in unrelated test files; lint on the changed files is clean.
  • cargo clippy --manifest-path src-tauri/Cargo.toml -- -D warnings passed.
  • A scratch Chromium harness rendered the actual InfoBar and stylesheet, confirming distinct computed pill backgrounds, hidden default/manual pills, unknown-mode fallback, and contrast ratios above 7:1 for both new pills. The full Playwright E2E suite was not run.

@delexw delexw left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Reviewed and verified locally against current main: tsc, oxlint, oxfmt, clippy, vitest and cargo test all pass.

@delexw
delexw merged commit f8650a8 into delexw:main Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Compat] Claude Code v2.1.284: Auto mode becomes default permission mode — no distinct InfoBar pill style

2 participants