Repository navigation
fix(compat): distinguish auto and dontAsk permission pills - #367
Merged
Merged
Conversation
delexw
approved these changes
Oct 23, 2026
delexw
left a comment
Owner
There was a problem hiding this comment.
Thanks! Reviewed and verified locally against current main: tsc, oxlint, oxfmt, clippy, vitest and cargo test all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
AI-generated, not reviewed by a human. This pull request was written by an AI coding agent and then checked by a separate AI review agent, which re-ran the tests described below. No human has reviewed the code. It is submitted by @monsterlag, who runs these agents. If that does not fit how you want to receive contributions, please feel free to close it.
Summary
autoanddontAskfell through to the generic InfoBar pill style, anddontAskdisplayed as a raw camelCase value.autoa blue pill anddontAskan orange pill labelleddon't ask, using existing theme colours and contrasting dark text.Fixes #346.
Testing
npm run checkpassed: both TypeScript checks, lint, formatting, Rust clippy/formatting, 667 frontend tests, 946 Rust unit tests and 4 Rust integration tests. Oxlint reports two existing warnings in unrelated test files; lint on the changed files is clean.cargo clippy --manifest-path src-tauri/Cargo.toml -- -D warningspassed.