feat(figma): make a Section selection list something a caller can choose from - #13
Merged
Merged
Conversation
…ose from A Section link answers with candidates rather than screens, and the list gave a name, a type and a URL. That is not enough to tell two frames apart when a designer named them alike, so the choice was a guess and the wrong guess costs a full export. Each candidate now carries a preview of the visible text under it, bounded to 120 characters per candidate, 64 nodes walked, and 2 KiB across the whole list, so the index stays compact. An empty or short preview means the walk found little text, not that the screen is empty. The list also says how complete it is - selection.status and selection.count - with truncated read from the index rather than inferred from a round count of 100, which called a Section holding exactly that many partial. And nextAction carries an example built from this call's own artifactId and a candidate actually in the list, so the next step is a call to run rather than a shape to assemble. Taken from #10, which also re-implemented the multi-root cursor handling that #9 already landed; only the selection-list half is here.
Contributor
Changepacksdevup-mcp@0.2.1 → 0.3.0 - crates/devup-mcp/Cargo.tomlMinor
Patch
devup-mcp-devup-ui@0.2.1 → 0.3.0 - crates/devup-mcp-devup-ui/Cargo.tomlMinor
Patch
devup-mcp-figma@0.2.1 → 0.3.0 - crates/devup-mcp-figma/Cargo.tomlMinor
Patch
devup-mcp-visual@0.2.1 → 0.2.2 - crates/devup-mcp-visual/Cargo.tomlPatch
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #10. That PR also re-implemented the multi-root cursor handling that #9 already landed - same function, same five checks, minus the missing-cursor-on-continuation case #9 catches - so only the selection-list half is here, rebased onto current main.
A Section link answers with candidates rather than screens, and the list gave a name, a type and a URL. That is not enough to tell two frames apart when a designer named them alike, so the choice was a guess and the wrong guess costs a full export.
extAction.example\ is built from this call's own \�rtifactId\ and a candidate actually in the list, so the next step is a call to run rather than a shape to assemble.
Verification
\cargo fmt --all -- --check, \cargo clippy --workspace --all-targets --all-features -- -D warnings, \cargo test --workspace --all-features\ (0 failed), \cargo insta test --check, and
ode --test crates/devup-mcp-figma/tests/explore_script_behavior.mjs\ (6 passed) all pass on this branch.