Skip to content

perf: reuse changelog calendar formatter for each commit - #1418

Open
MrPunyapal wants to merge 1 commit into
dev-null-sh:productionfrom
MrPunyapal:perf/reuse-changelog-date-formatter
Open

MrPunyapal wants to merge 1 commit into
dev-null-sh:productionfrom
MrPunyapal:perf/reuse-changelog-date-formatter

Conversation

@MrPunyapal

@MrPunyapal MrPunyapal commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Change

Reuses one calendar date formatter while grouping changelog commits. Date grouping continues to use the viewer’s locale and timezone.

Tests

Focused changelog date tests passed (5 tests). Type checks and lint passed.

Summary by CodeRabbit

  • Bug Fixes
    • Changelog commit dates now display consistently in the requested time zone, using a standardized date format. Commits with invalid timestamps are retained and grouped under “Invalid Date” rather than disrupting date display. Valid commits continue to be grouped by their date in the selected time zone, including when the time zone differs from the viewer’s local setting.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

changelogDays uses a timezone-aware formatter for valid commit timestamps and groups invalid timestamps under Invalid Date. A unit test checks both outcomes.

Changes: Changelog date formatting

Layer / File(s) Summary
Format commit dates
resources/js/lib/changelog.ts, tests/Unit/Changelog.test.ts
changelogDays formats valid timestamps in the supplied time zone and assigns invalid timestamps the Invalid Date label. The test checks both date groups.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Refactor

Possibly related PRs

Suggested reviewers: nunomaduro

Merge Risk: Minimal · up to c36b2

No actionable merge-blocking risk remains in the reviewed changes.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main performance change: reusing one changelog calendar formatter while processing commits.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f1b3f0ec-0bf4-4021-ad47-c4112d82a553
Commits

Reviewing files that changed from the base of the PR and between f8ba1b6 and c36b2d8.

Files selected for processing: 2
  • resources/js/lib/changelog.ts
  • tests/Unit/Changelog.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

@MrPunyapal
MrPunyapal force-pushed the perf/reuse-changelog-date-formatter branch from 325bce7 to 1ee4a68 Compare November 3, 2026 05:55
@MrPunyapal
MrPunyapal marked this pull request as ready for review November 3, 2026 06:02

@coderabbitai coderabbitai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix comments: Fix CodeRabbit comments on this PR

Comment thread resources/js/lib/changelog.ts Resolved
@MrPunyapal
MrPunyapal force-pushed the perf/reuse-changelog-date-formatter branch from f8ba1b6 to c36b2d8 Compare November 4, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant