You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
perf: reuse changelog calendar formatter for each commit - #1418
Reuses one calendar date formatter while grouping changelog commits. Date grouping continues to use the viewer’s locale and timezone.
Tests
Focused changelog date tests passed (5 tests). Type checks and lint passed.
Summary by CodeRabbit
Bug Fixes
Changelog commit dates now display consistently in the requested time zone, using a standardized date format. Commits with invalid timestamps are retained and grouped under “Invalid Date” rather than disrupting date display. Valid commits continue to be grouped by their date in the selected time zone, including when the time zone differs from the viewer’s local setting.
No actionable comments were generated in the recent review.
Walkthrough
changelogDays uses a timezone-aware formatter for valid commit timestamps and groups invalid timestamps under Invalid Date. A unit test checks both outcomes.
Changes: Changelog date formatting
Layer / File(s)
Summary
Format commit dates resources/js/lib/changelog.ts, tests/Unit/Changelog.test.ts
changelogDays formats valid timestamps in the supplied time zone and assigns invalid timestamps the Invalid Date label. The test checks both date groups.
No actionable merge-blocking risk remains in the reviewed changes.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly describes the main performance change: reusing one changelog calendar formatter while processing commits.
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: f1b3f0ec-0bf4-4021-ad47-c4112d82a553
Commits
Reviewing files that changed from the base of the PR and between f8ba1b6 and c36b2d8.
Files selected for processing: 2
resources/js/lib/changelog.ts
tests/Unit/Changelog.test.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Reuses one calendar date formatter while grouping changelog commits. Date grouping continues to use the viewer’s locale and timezone.
Tests
Focused changelog date tests passed (5 tests). Type checks and lint passed.
Summary by CodeRabbit