[MrPunyapal]

Problem

Click handling on a commit can treat nested accessible controls as clicks on the commit itself, preventing the control from working as intended.

Change

Excludes supported interactive and ARIA controls from commit-level click navigation while preserving normal and modified commit links.

Tests

The full JavaScript unit suite passed (224 tests). Type checks and lint passed.

Summary by CodeRabbit

• Bug Fixes
  • Clicking switches, tabs, sliders, and combo boxes—or their nested content—no longer triggers commit navigation.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The commit click selector now matches elements with switch, tab, slider, and combobox roles. Unit tests cover clicks on these elements and their nested spans.

Changes: Commit click control handling

Layer / File(s)	Summary
Extend interactive target matching resources/js/lib/commit-click.ts, tests/Unit/CommitClick.test.ts	The selector adds four ARIA roles. Tests verify that clicks on those controls and nested spans return null from clickedCommit.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: nunomaduro

Merge Risk: Minimal · up to d98ac

No actionable merge-blocking risk was identified in this focused change.

Architecture risk: Low · up to d98ac

The change affects 2 systems.

Changed systems: resources, tests

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — resources (service) was modified; 1 changed file maps to changed impact.
• observed — tests (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

• observed — Modified behavior in resources/js/lib/commit-click.ts: The interactive-element selector adds the switch, tab, slider, and combobox ARIA roles.
• observed — Modified behavior in tests/Unit/CommitClick.test.ts: Adds coverage that clicking any of the listed accessible controls or a nested span returns null from clickedCommit.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: preventing accessible controls inside commits from triggering commit navigation.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

• Mode: Continue automatically
• Reviewed files: 2
• Waived: $0.50 (charged $0.00)
• View usage details

Note

This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews.

CodeRabbit Verify

• Run CodeRabbit Verify to test the changes in this pull request.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: f96081a4-02cc-4ad5-b4e8-9bafaf34afeb

Commits

Reviewing files that changed from the base of the PR and between c934501 and d98acf4.

Files selected for processing: 2

• resources/js/lib/commit-click.ts
• tests/Unit/CommitClick.test.ts

Limit details: You’ve used all 10 included reviews currently available.