You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
perf: calculate voice waveform peaks without slice allocations - #1428
Calculates voice waveform peaks directly from each range instead of allocating sliced arrays. Peak values and boundaries are preserved, including empty input.
Validation
The full JavaScript unit suite passed (225 tests). A synthetic Node benchmark showed about a 3x reduction for 1,200 samples across 10,000 calls, but the application calculates a waveform once per recording, so the real user impact is small and has not been measured in a target browser. This remains a draft pending confirmation that the added complexity is worthwhile.
Summary by CodeRabbit
Bug Fixes
Improved voice-note audio visualizations for long recordings, preserving prominent peaks without losing detail.
Empty audio data is now handled gracefully when generating visualizations.
Review was skipped as selected files did not have any reviewable changes.
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 547e1b55-c680-4b58-8324-53e49487a193
Commits
Reviewing files that changed from the base of the PR and between fc0f56a and c1640d0.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
barsOf now returns zero for empty input and finds each bar’s peak by iterating over its source range. Tests cover long sequences, negative values, NaN, and sparse-array holes.
Changes: Voice note bar calculation
Layer / File(s)
Summary
Bar calculation and validation resources/js/lib/voice-notes.ts, tests/Unit/VoiceNotes.test.ts
barsOf returns zero bars for empty input and finds peaks by iterating over each bar’s range. Tests verify peak retention in a long sequence and behavior for negative values, NaN, and sparse-array holes.
The waveform calculation change preserves existing behavior while removing slice allocations; no merge-blocking risk was identified.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: calculating voice waveform peaks without slice allocations. It matches the implementation and PR objective.
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
CodeRabbit Verify
Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: af7987fa-d448-4b55-acfb-2785b14da705
Commits
Reviewing files that changed from the base of the PR and between c934501 and fc0f56a.
Files selected for processing: 2
resources/js/lib/voice-notes.ts
tests/Unit/VoiceNotes.test.ts
Limit details: You’ve used all 10 included reviews currently available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Calculates voice waveform peaks directly from each range instead of allocating sliced arrays. Peak values and boundaries are preserved, including empty input.
Validation
The full JavaScript unit suite passed (225 tests). A synthetic Node benchmark showed about a 3x reduction for 1,200 samples across 10,000 calls, but the application calculates a waveform once per recording, so the real user impact is small and has not been measured in a target browser. This remains a draft pending confirmation that the added complexity is worthwhile.
Summary by CodeRabbit