Skip to content

Surveyor misses live Bugbot requests when a connector adds a footer #606

Closed

Description

@devantler

🤖 Generated by the Agentic Engineer

Problem

The surveyor pairs a Bugbot request marker only with the next exact-author bare trigger. A request with a connector-added footer starts the same review but is invisible to this pairing rule, so another instance can request a duplicate review at the same head.

Reproduced evidence

At main c759182ac59d550f8d1f3d5b03d86f2fa0e79b06, the surveyor definition still requires a bare trigger. In the consuming deployment, the actual marker check's complete regression suite passes first-line commands with trailing text or a footer, and rejects a command below the disclosure line. This run independently exercised those cases. The contradictory definition remains in the consumer overlay and review guide (devantler-tech/monorepo#3955).

Intended outcome

Use the same conservative trigger boundary for request accounting: the next exact-author comment whose first nonblank line names the command. Keep the authenticated disclosure, exact author, provider and full-head marker requirements; a request marker or counted trigger ends the pairing window. Interleaved other-author comments remain ignored. This changes observation and deduplication only: emitted requests remain the canonical bare trigger, and review findings and readiness gates remain mandatory.

Acceptance

  • The portable surveyor describes the first-line boundary, including connector footers and trailing text.
  • A command below a disclosure line neither pairs nor closes the pending marker window.
  • A focused regression rejects a return to bare-only pairing and protects the authentication, head and window boundaries.
  • Bump the plugin's cache version through its supported writer and validate manifests, tests and the resulting installed package before protected merge.
  • Consume the merged definition in monorepo#3955; upstream source delivery alone does not finish that deployment issue.

Activity

  1. self-assigned this
    on Oct 26, 2026
  2. added theissue type on Oct 26, 2026
  3. moved this to 🏃🏻‍♂️ In Progress in 🌊 Project Boardon Oct 26, 2026
  4. moved this from 🏃🏻‍♂️ In Progress to ✅ Done in 🌊 Project Boardon Oct 26, 2026
  5. devantler commented on Oct 26, 2026

    @devantler
    ContributorAuthor

    🤖 Generated by the Agentic Engineer

    Delivered through PR #607, signed protected merge efd8c1c319a55f3ec16e1b7b3ed9698dfcd59514. Independent verification confirms that the entire merge tree matches the reviewed head. The exact-head Codex review is finding-free, every review finding is resolved, and the actual merged-main CI passed all eight selected jobs with one intentional skip.

    A fresh native skills installation from the reviewed commit independently matches all 31 skill bodies and 136 supporting files, including exact source/tree provenance. The consumer regression rejects the old bare-only rule and passes the corrected boundary on both supported Bash versions. Version 6.6.9, its changelog and canonical desired-state digest are delivered together. This completes the portable source/package correction; actual consumer adoption remains open in devantler-tech/monorepo#3955 and no running-process reload is claimed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Fields

Priority

Medium

Effort

Low

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions