Repository navigation
fix(flux): bind Kustomization readiness to each request - #8117
Conversation
Local validation for signed head The regression first failed against the old implementation: a stale failure at the same source revision terminated a new attempt. It now waits for a fresh matching controller receipt and succeeds. Controls retain the original deadline when acknowledgement never arrives, skip suspended resources, stop blocked dependencies before a new request, and promptly report a genuine fresh failure even when Flux retains Those regression scenarios use a scripted Kubernetes API boundary, not a live-controller recovery claim. The completion handling follows the upstream controller’s final status update. Native Flux system-test execution, full current-head CI and substantive review remain pending. #8115 deliberately stays open for its separate later Platform deployment observation; platform#5692 still owns the underlying webhook deadline. |
✅MegaLinter analysis: Success✅ Linters with no issuesactionlint, bash-exec, git_diff, hadolint, jscpd, jsonlint, lychee, markdown-table-formatter, markdownlint, prettier, prettier, shellcheck, shfmt, stylelint, syft, trivy-sbom, trufflehog, v8r, v8r, yamllint See detailed reports in MegaLinter artifacts
|
Code coverage overviewLanguages: Go Go / code-coverage/go
View coverage of the 3 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. |
@coderabbitai full review |
Action not completed
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Readiness verified at The real CLI path is exercised in the Vanilla/Flux system test. It downloads the verified binary artifact from the same run’s producer, built from merge source Promoting for protected delivery. #8115 remains open for publication and its separate later Platform retry observation; that production outcome is not claimed by this test. |

Why
Retries can immediately reuse a previous reconciliation failure, wasting their recovery opportunity and blocking deployment feedback. Each attempt needs a result from the controller for that attempt.
What
Wait for fresh reconciliation results for each monitored Flux Kustomization while preserving prompt real failures and the existing timeouts. Suspended resources stay suspended and do not hold up the command.
Part of #8115