Repository navigation
fix: keep DOT line-break escapes intact in lineage labels - #890
Merged
Merged
Conversation
_escape_dot escaped every backslash (text.replace("\\", "\\\\")), so the DOT
centered-newline escape `\n` the label builders insert became `\\n`, which
Graphviz renders as a literal backslash-n. Multi-line node/edge labels therefore
collapsed onto a single line.
Escape only backslashes that do not begin a DOT line-break escape (\n/\l/\r), so
intentional line breaks survive while stray backslashes and quotes are still
escaped. Verified by rendering with dot.
Closes #889
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rendered
lafleur-lineagegraphs showed node labels with literal\non one line (e.g.444.py\nsniper (3 transformers)\ndepth=6…).Cause: the label builders insert the DOT centered-newline escape
\n, but_escape_dotescaped every backslash (\→\\), turning\ninto\\n; Graphviz renders\\as a literal backslash.Fix:
_escape_dotnow escapes only backslashes that are not part of a DOT line-break escape (\n/\l/\r), preserving intentional line breaks while still escaping stray backslashes and quotes.Verification
Rendered the exact broken label with
dot -Tpngbefore/after — after the fix it renders as four lines (444.py/sniper (3 transformers)/depth=6 finds=1/density=0.000 edges=0).Test plan
TestEscapeDot: line-break escapes preserved; stray backslash + quote still escaped; real multi-line label round-trips.mypy lafleurclean;ruffclean.Closes #889
🤖 Generated with Claude Code