Repository navigation
Add fish shell completion - #69
montionugera wants to merge 2 commits into
Conversation
- Add completions/btc-toolkit.fish with subcommands and flags mirroring btc-toolkit.zsh - Extend tests/test_completions.py to ensure fish completions match build_parser() - Mention fish in README.md shell completion docs and architecture overview - Update CHANGELOG.md under [Unreleased] Closes devdavidejesus#62
|
Thanks a lot for this, and welcome! It's the project's first outside contribution. I tested it in a real fish shell (3.7.0): all 11 commands, their flags and the networks complete correctly, and the tests pass. Two small changes before I merge:
Then I'll merge. |
|
Thanks for the review and testing, @devdavidejesus! Updated both points:
|
What and why
Adds static fish shell completions (
completions/btc-toolkit.fish) mirroringcompletions/btc-toolkit.zshfor all 11 subcommands and their supported flags, extendstests/test_completions.pyto ensure fish completions stay synchronized withbuild_parser(), and documents fish completion inREADME.mdandCHANGELOG.md.Closes #62
Checklist
tests/(unittest, API calls mocked, runs offline)python -m coverage run -m unittest discover -s tests -t .thenpython -m coverage report(90% or more)ruff check btc_toolkit/ tests/ fuzz/ .github/scripts/andmypy --strict btc_toolkit/passfuzz/fuzz_parsers.py--jsonkeys only added, never renamed or removed (docs/json-schema.md)[Unreleased]inCHANGELOG.md