Repository navigation
Un-retire call_stack_diff with diagrams on - #1549
Merged
Merged
Conversation
A diagram with before and after scenarios does not replace it: a call stack marks each frame added, removed or modified from the diff, and a diagram's scenarios are authored. Agents can insert one again, and the authoring guide names it for the implementation section. Agent-Session: db53cef1-7052-40f4-80b7-97044c16c38b Agent-Session: cfa09165-90bc-452b-ae64-4d30f1b1b967 Agent-Session: e0ce88b4-2b12-4893-b928-d677481aceb0 Agent-Session: cbacb871-2558-4fe4-9272-77524bb21683
thesiti92
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
With the Diagrams and Animations setting on, agents can insert a
call_stack_diffagain, and the authoring guide names it for the implementation section.call_stack_diffis out ofRETIRED_BLOCK_TYPES, so an insert no longer gets a 409.call_stack_diffline for the old vs. new path, in place of "adiagram… as two scenarios (before, after)".call_stack_diffandframeagain.animation,clip,flow_diagramandsequencestay retired. Nothing changes with the setting off.Why
#1531 retired
call_stack_diffon the grounds that a diagram draws what it did. It does not:codeis optional.Testing
animation-authoring.test.ts,authoring-pitfalls.test.tsandanimation-drafts.test.tspass. Not checked in Desktop.