Skip to content

Un-retire call_stack_diff with diagrams on - #1549

Merged
milanb17 merged 1 commit into
mainfrom
mb/authoring-guidance-audit-ddfff4
Nov 16, 2026
Merged

milanb17 merged 1 commit into
mainfrom
mb/authoring-guidance-audit-ddfff4

Conversation

@milanb17

Copy link
Copy Markdown
Contributor

What

With the Diagrams and Animations setting on, agents can insert a call_stack_diff again, and the authoring guide names it for the implementation section.

  • call_stack_diff is out of RETIRED_BLOCK_TYPES, so an insert no longer gets a 409.
  • The setting-on authoring topic keeps the call_stack_diff line for the old vs. new path, in place of "a diagram … as two scenarios (before, after)".
  • The Components list includes call_stack_diff and frame again.

animation, clip, flow_diagram and sequence stay retired. Nothing changes with the setting off.

Why

#1531 retired call_stack_diff on the grounds that a diagram draws what it did. It does not:

  • A call stack marks each frame added, removed or modified from the real diff. A diagram's before and after scenarios are authored, and nothing checks them.
  • A frame must name a code range. A diagram node's code is optional.
  • A call stack is a tree with call sites. A diagram has no call depth.

Testing

animation-authoring.test.ts, authoring-pitfalls.test.ts and animation-drafts.test.ts pass. Not checked in Desktop.

A diagram with before and after scenarios does not replace it: a call
stack marks each frame added, removed or modified from the diff, and a
diagram's scenarios are authored. Agents can insert one again, and the
authoring guide names it for the implementation section.

Agent-Session: db53cef1-7052-40f4-80b7-97044c16c38b
Agent-Session: cfa09165-90bc-452b-ae64-4d30f1b1b967
Agent-Session: e0ce88b4-2b12-4893-b928-d677481aceb0
Agent-Session: cbacb871-2558-4fe4-9272-77524bb21683
@milanb17
milanb17 merged commit 1e8588a into main Nov 16, 2026
3 checks passed
@milanb17
milanb17 deleted the mb/authoring-guidance-audit-ddfff4 branch November 16, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants