Skip to content

Scroll a tour to the clicked code when its stop shows several - #1552

Open
sidkmenon wants to merge 1 commit into
mainfrom
fix/tour-reveal-clicked-code
Open

sidkmenon wants to merge 1 commit into
mainfrom
fix/tour-reveal-clicked-code

Conversation

@sidkmenon

Copy link
Copy Markdown
Contributor

Clicking a drawn element (data-wb-open) in an animation or diagram moves the tour to the frame's stop, but the panel only scrolled to the stop's heading. When that stop lists several pieces of code and the clicked one isn't first, its card stayed out of view.

  • The click now carries the code's selectionKey as revealCode on the tour's reveal state (column peek and fullscreen overlay). The value is cleared on the next move.
  • GuidedTourPanel scrolls to the matching card (data-code-peek-key on CodePeekCard) instead of the heading. The first card, or code the stop doesn't show, still targets the heading.
  • Adds a browser test for revealing the second card in a two-card stop. It fails without the fix.

Agent-Session: 9467d5af-98ed-4da0-b22e-b96feb43df0f
Agent-Session: 8475fa2e-5cfe-4cf5-adb4-c03e8441117d

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant