Skip to content

Add a Niteshift environment that builds and runs Whiteboard Desktop - #1553

Draft
sidkmenon wants to merge 2 commits into
mainfrom
sidkmenon/niteshift-config
Draft

sidkmenon wants to merge 2 commits into
mainfrom
sidkmenon/niteshift-config

Conversation

@sidkmenon

Copy link
Copy Markdown
Contributor

Adds a Niteshift environment for this repo, so each task starts with Whiteboard Desktop built and running in the sandbox.

What's included

  • .niteshift/setup (safe to rerun; about 3.5 min on a fresh disk, 7–12 s when already built). It:
    • installs the Node version pinned in apps/review-desktop/code-oss/.nvmrc (24.22.1) under /opt. This one install covers both the monorepo (Node 24) and the Code OSS fork, and the sandbox's own Node stays untouched.
    • apt-installs the native-module headers CI uses: libx11-dev, libxkbfile-dev, libkrb5-dev and libsecret-1-dev.
    • runs pnpm install --frozen-lockfile, then REVIEW_DESKTOP_DEV_FAST=1 pnpm desktop:build. Code OSS npm ci runs only when its lockfile digest changes.
    • builds the Review server and canvas through run.sh's own freshness helper, so the desktop launches quickly.
    • installs Playwright Chromium for the canvas browser tests.
  • .niteshift/services.yaml: one desktop service that runs pnpm desktop:run on the sandbox display (:99), which the user watches in the Agent preview. Whiteboard has no web UI, so the service has no port and no web preview. Electron's remote debugging is on port 9333, so agents can drive the renderer with agent-browser --cdp 9333.
  • apps/review-desktop/scripts/run.sh: a new opt-in DEV_FAST_REVIEW_NO_SANDBOX=1 switch that passes --no-sandbox, built like the existing DEV_FAST_REVIEW_DISABLE_GPU switch.
    • Why: the sandbox runs as root, and Electron aborts as root unless --no-sandbox is on its command line.
    • What I ruled out: disable-chromium-sandbox in argv.json, which takes effect too late.
    • The packaged launcher already supports --no-sandbox on Linux. The dev script had no way to pass it.
    • Reviewers: this is the only change outside .niteshift/.

Verification

  • prove-lifecycle: both setup runs, validate, up and status all read ok, and setup leaves the working tree unchanged.
  • ns services restart desktop: the workbench loads, and the logs show the Review server reporting ready.
  • whiteboard instances lists dev-whiteboard-… as running. DEV_REVIEW_INSTANCE=<key> whiteboard info returns {"event":"info","reviews":[]} from the running Desktop.
  • vitest --project browser src/ui/copy.browser.test.tsx passes on the installed Chromium.

Screenshots

Whiteboard Desktop on the sandbox display:

🤖 Generated with Claude Code
🌒 Run on Niteshift: View Task

sidkmenon and others added 2 commits November 18, 2026 23:40
Setup installs the pinned Node 24, Code OSS native build headers, monorepo
dependencies, a dev-fast Desktop build and Playwright Chromium. The desktop
service launches Whiteboard Desktop on the sandbox display.

run.sh gains DEV_FAST_REVIEW_NO_SANDBOX=1, which passes --no-sandbox so the
dev Desktop can start as root in containers.

Run-on: Niteshift
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The sandbox has no GPU, but Chromium falls back to software rendering on its
own, and --disable-gpu can leave the canvas's WebGL views without a context.

Run-on: Niteshift
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant