Skip to content

Show PR numbers beside PR boards in the sidebar and on Home - #1557

Draft
sidkmenon wants to merge 1 commit into
mainfrom
sidkmenon/pr-numbers-in-lists
Draft

sidkmenon wants to merge 1 commit into
mainfrom
sidkmenon/pr-numbers-in-lists

Conversation

@sidkmenon

Copy link
Copy Markdown
Contributor

Summary

Rows for PR boards now show the PR number (#1550) so you can refer to a PR without hovering over its state icon. Asked for in #jukebox.

  • Sidebar (This board, Recent, and search): the number sits just before the state icon. The space for the hover "+" child-board button stays between the number and the icon, so the button still covers neither.
  • Home list: the number follows the title's last word.
  • A new kit piece, PullRequestNumber in ui/board-icons.tsx, renders the number in faint mono with tabular digits. It is aria-hidden because the state icon's label ("PR Import the host's ProseMirror in @dev.fast/canvas instead of bundling one #1550, open") already names the PR to screen readers.

Verification

  • Rendered the sidebar list and the Home list in Chromium with open, closed and merged PR boards and one board with no PR, in light and dark. Screenshots below.
  • sidebar-sections.browser.test.tsx and review-home-view.browser.test.tsx: 60/60 pass. This includes the existing check that keeps PR markers aligned with the "+" button at 320px and 180px widths.
  • pnpm lint and pnpm format are clean.
  • Not checked in an isolated Review Desktop: this sandbox can't run it.

Screenshots


🤖 Generated with Claude Code
🌒 Run on Niteshift: View Task

Rows for boards that came from a PR now print "#1550" next to the state
icon, so a PR can be named at a glance instead of by hovering.

Run-on: Niteshift
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant