Skip to content

Let a wheel gesture that starts at rest over a code peek or database lens scroll it - #1558

Merged
ketan0 merged 1 commit into
mainfrom
ketan/wheel-latching
Nov 20, 2026
Merged

ketan0 merged 1 commit into
mainfrom
ketan/wheel-latching

Conversation

@ketan0

@ketan0 ketan0 commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

A vertical wheel gesture now latches to where it starts. If it starts at rest over a code peek or database lens that can scroll, the embed scrolls alone until the gesture ends, and the page doesn't move at the edge. Starting anywhere else scrolls the document past embeds, as before.

  • A gesture ends after 150ms of wheel quiet, so trackpad momentum stays part of the same gesture.
  • Code OSS editors skip wheel events that are already cancelled, and they don't cancel the ones they handle. So a bubble-phase listener cancels the event after the peek has handled it, which keeps the document still.
  • To tell whether a peek can scroll, the router checks whether the editor's vertical scrollbar slider has a height.

Tested with browser tests, and with real wheel events sent over CDP to a dev Desktop: scrolling at rest, scrolling past the top and bottom edges, and a gesture that starts on the prose.

🤖 Generated with Claude Code

…lens scroll it

Agent-Session: 01a0d12e-51ca-7230-9991-0ce7a73018b2
@ketan0
ketan0 enabled auto-merge (squash) November 20, 2026 03:20
@ketan0
ketan0 merged commit 6aed828 into main Nov 20, 2026
3 checks passed
@ketan0
ketan0 deleted the ketan/wheel-latching branch November 20, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants