Repository navigation
docs: say the offline suite runs in the same CI step as bash -n - #36
Conversation
CLAUDE.md:196-198 told a maintainer the offline suite runs "in the step after the `bash -n` loop". .github/workflows/shell-checks.yml:44-56 runs both in the same `run:` body, and the workflow's own comment at :29-33 forbids a second job or a second `run:` step. Restate the CI section to match the workflow, and sweep the neighbouring Testing-section claims against .github/run-tests.sh and the workflow rather than against the old doc text. The workflow file is not touched. Dz-Task-Id: tsk_56a4d72257d7f8f18efa4f296f991919
✅ Reviewed — nothing blocking0 actionable comment(s) · grounded on your code ⏱ 59s wall clock · 🤖 developerz.ai — automated review, running on your model and your box. |
There was a problem hiding this comment.
Review summary — 1 file(s), 0 finding(s).
Rewrites CLAUDE.md's CI section so the offline suite is documented as riding in the same run: step as the bash -n loop, and lists that step's four commands. Prose only: no shell code, workflow or test change, and the new claims stay consistent with the file's Testing section.
- test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against
🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by router/deepseek-v4.1-flash on box hv-dedicated-ci-1 — 15.3k in / 3.56k out over 1 call, on your flat-rate plan: no per-token charge (~<$0.01 at list price).
What
CLAUDE.md:196-198 told a maintainer the offline suite runs "in the step
after the
bash -nloop". .github/workflows/shell-checks.yml:44-56 runsboth in the same
run:body, and the workflow's own comment at :29-33forbids a second job or a second
run:step.Restate the CI section to match the workflow, and sweep the neighbouring
Testing-section claims against .github/run-tests.sh and the workflow
rather than against the old doc text. The workflow file is not touched.
Acceptance
run:step as thebash -nloop, matching .github/workflows/shell-checks.yml:44-56.run:step or a second job;grep -n 'step after' CLAUDE.mdreturns nothing.bash -nloop (:47-49),bash .github/run-tests.sh(:56), the deliberate-failure probe (:58-79) andbash .github/run-tests_test.sh(:86) all sit in the one step named 'Check Bash syntax and run the offline test suit [trimmed]bash .github/run-tests.shexits 0 offline, so the command CLAUDE.md documents still runs the nine members green.Changes
CLAUDE.md(edit) — Fix the CI prose at CLAUDE.md:196-198: the offline suite runs in the SAMErun:step as thebash -nloop — the step named 'Check Bash syntax and run the offline test suite' (shell-checks.yml:44-56) — not in a later step; drop the phrase 'in the step after thebash -nloop' and mirror the workflow's own rule at :29-33 (no second job, no secondrun:step). Sweep :182-204 and the suite claims at :119-140 against shell-checks.yml and .github/run-tests.sh; correct anything wrong. Prose only.Verification
No check command was found for this repository, so no gate ran before the commit.
What the editors ran to see the change working, and what they saw:
bash .github/run-tests.sh (redirected to $TMPDIR/mini-suite.log)(docs): EXIT=0 — log ends with 'PASS tests/webfetch.sh', 'PASS: 47 checks', and 'All 9 test script(s) passed.' (nine members, the command CLAUDE.md documents)grep -n 'step after' CLAUDE.md(docs): no output, grep exit 1 — the phrase is gone from the filecode_changes (working-tree diff) + code_changes --paths CLAUDE.md(docs): Only CLAUDE.md is modified; the diff is one prose hunk in the ## CI section (lines 195-208). .github/workflows/shell-checks.yml, .github/run-tests.sh, docs/ and README.md appear in no diff.code_read CLAUDE.md (CI section, lines 182-212)(docs): CI section now states the suite rides in the SAME step as thebash -nloop (step named 'Check Bash syntax and run the offline test suite'), lists that step body's four commands (bash -n loop, bash .github/run-tests.sh, the deliberately-failing-member probe, bash .github/run-tests_test.sh), and keeps the 'shell-checks is the one check name' paragraph intactNotes
Premises of the request the team disproved:
🤖 Opened by developerz.ai for task
tsk_56a4d72257d7f8f18efa4f296f991919on developerz-ai/mini.Raised automatically by the
raw_task_triagelane.