Skip to content

Markup component will not update if the mapping of custom elements change #25

Description

@d3x7r0

When using the option to add a map of custom elements the component will not update if said mapping changes.

I think the problem might be here:

shouldComponentUpdate({ wrap, type, markup }) {
let p = this.props;
return wrap!==p.wrap || type!==p.type || markup!==p.markup;
}

Now I don't know if this is intended behaviour or just a oversight.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions