feat!: eslint-plugin-import-x 4.18 with its barrel-file rules on; patch minimatch and zod

package.json

@@ -94,7 +94,7 @@
   "dependencies": {
     "eslint-config-prettier": "^10.1.8",
     "eslint-import-resolver-typescript": "^4.4.5",
-    "eslint-plugin-import-x": "^4.17.1",
+    "eslint-plugin-import-x": "^4.18.1",
     "globals": "^17.13.0",
     "jsonc-parser": "^3.3.1",
     "yaml": "^2.9.1"

pnpm-workspace.yaml

@@ -1,2 +1,8 @@
 allowBuilds:
   unrs-resolver: false
+overrides:
+  # GHSA-g3hv-75wg-m249 (minimatch < 11.0.1): eslint and typescript-eslint still ask for ^10, which has no fix.
+  # Drop this once they allow 11.
+  'minimatch@<11.0.1': ^11.0.1
+  # GHSA-mrhx-c7xc-m3w5 (zod < 4.6.6), through knip and @angular/forms; their ranges allow the fix
+  'zod@<4.6.6': ^4.6.6

scripts/rules-add.mjs

@@ -12,7 +12,7 @@ import path from 'node:path';
 import process from 'node:process';
 import { fileURLToPath } from 'node:url';
 
-import * as prettier from 'prettier';
+import { format, resolveConfig } from 'prettier';
 
 import { gaps, inventories } from './rule-inventory.mjs';
 
@@ -70,8 +70,8 @@ async function main() {
       remove,
       add: undecided.map((rule) => [rule, inventory.initial(rule)]),
     });
-    const options = await prettier.resolveConfig(file);
-    writeFileSync(file, await prettier.format(updated, { ...options, filepath: file }));
+    const options = await resolveConfig(file);
+    writeFileSync(file, await format(updated, { ...options, filepath: file }));
     changed += undecided.length + remove.length;
     for (const rule of undecided) {
       console.log(`${inventory.file}: added ${rule}: ${JSON.stringify(inventory.initial(rule))}`);

src/eslint/index.mjs

@@ -7,8 +7,6 @@ import { typescript } from './layers/typescript.mjs';
 import { vitest } from './layers/vitest.mjs';
 import { normalizeOptions, OPTIONS_SETTING } from './options.mjs';
 
-export { angular, ignores, imports, javascript, normalizeOptions, prettier, typescript, vitest };
-
 /** @typedef {import('./options.mjs').Options} Options */
 /** @typedef {import('eslint').Linter.Config} Config */
 

src/eslint/rules/angular-template.mjs

@@ -1,7 +1,7 @@
 /*
  * @angular-eslint/template rules. Every plugin rule is listed; effective configuration.
  */
-export default /** @type {import('eslint').Linter.RulesRecord} */ ({
+const rules = /** @type {import('eslint').Linter.RulesRecord} */ ({
   '@angular-eslint/template/alt-text': 'error',
   '@angular-eslint/template/attributes-order': 'error',
   '@angular-eslint/template/banana-in-box': 'error',
@@ -56,3 +56,5 @@ export default /** @type {import('eslint').Linter.RulesRecord} */ ({
   '@angular-eslint/template/require-switch-default': 'error',
   '@angular-eslint/template/prefer-style-binding': 'error',
 });
+
+export default rules;

src/eslint/rules/angular.mjs

@@ -1,7 +1,7 @@
 /*
  * @angular-eslint rules for TypeScript. Every plugin rule is listed; effective configuration.
  */
-export default /** @type {import('eslint').Linter.RulesRecord} */ ({
+const rules = /** @type {import('eslint').Linter.RulesRecord} */ ({
   // prefix comes from createConfig({ angular: { prefix } }); the angular layer sets the options
   '@angular-eslint/directive-selector': 'error',
   '@angular-eslint/component-selector': 'error',
@@ -62,3 +62,5 @@ export default /** @type {import('eslint').Linter.RulesRecord} */ ({
   // previously crashed on Signal Forms destructuring; verified fixed by test/lint.test.mjs
   '@angular-eslint/reactive-context-must-read-signal': 'error',
 });
+
+export default rules;

src/eslint/rules/imports.mjs

@@ -4,7 +4,7 @@
  * Resolution-based rules are off except no-cycle: TypeScript already reports unresolved modules
  * and missing named exports. The imports layer configures the TypeScript resolver for no-cycle.
  */
-export default /** @type {import('eslint').Linter.RulesRecord} */ ({
+const rules = /** @type {import('eslint').Linter.RulesRecord} */ ({
   // -- ordering and layout --
   // groups and internal patterns are set by the imports layer
   'import-x/order': 'error',
@@ -68,4 +68,14 @@ export default /** @type {import('eslint').Linter.RulesRecord} */ ({
   'import-x/no-dynamic-require': 'error',
   // Node built-ins are expected in Node projects; browser builds fail without polyfills anyway
   'import-x/no-nodejs-modules': 'off',
+  // -- barrel files: a module that mostly re-exports others makes every importer load all of them --
+  'import-x/avoid-barrel-files': 'error',
+  // also through dependencies: import the module itself (lodash-es/debounce), not the package's barrel
+  'import-x/avoid-importing-barrel-files': 'error',
+  // `import * as x` hides which exports are used and defeats tree-shaking; import them by name
+  'import-x/avoid-namespace-import': 'error',
+  // `export * from` makes the API whatever the other module exports; name the exports
+  'import-x/avoid-re-export-all': 'error',
 });
+
+export default rules;

src/eslint/rules/javascript.mjs

@@ -2,7 +2,7 @@
  * Core ESLint rules. Every non-deprecated core rule is listed; this table is the effective
  * configuration (see docs/specs). Formatting is owned by Prettier.
  */
-export default /** @type {import('eslint').Linter.RulesRecord} */ ({
+const rules = /** @type {import('eslint').Linter.RulesRecord} */ ({
   // possible logic errors
   'array-callback-return': 'error',
   'constructor-super': 'error',
@@ -242,3 +242,5 @@ export default /** @type {import('eslint').Linter.RulesRecord} */ ({
   yoda: 'error',
   'unicode-bom': 'error',
 });
+
+export default rules;

src/eslint/rules/typescript.mjs

@@ -3,7 +3,7 @@
  * Every rule in typescript-eslint's `all` config is listed; this table is the effective
  * configuration for TS files.
  */
-export default /** @type {import('eslint').Linter.RulesRecord} */ ({
+const rules = /** @type {import('eslint').Linter.RulesRecord} */ ({
   '@typescript-eslint/adjacent-overload-signatures': 'error',
   '@typescript-eslint/array-type': 'error',
   '@typescript-eslint/await-thenable': 'error',
@@ -231,3 +231,5 @@ export default /** @type {import('eslint').Linter.RulesRecord} */ ({
   '@typescript-eslint/no-unnecessary-type-conversion': 'error',
   '@typescript-eslint/no-generated-empty-object-type': 'error',
 });
+
+export default rules;

src/eslint/rules/vitest.mjs

@@ -1,7 +1,7 @@
 /*
  * @vitest/eslint-plugin rules. Every non-deprecated plugin rule is listed; effective configuration.
  */
-export default /** @type {import('eslint').Linter.RulesRecord} */ ({
+const rules = /** @type {import('eslint').Linter.RulesRecord} */ ({
   // -- Assertions --
   // helpers named expect* (e.g. expectValid(...)) count as assertions
   'vitest/expect-expect': ['error', { assertFunctionNames: ['expect', 'expect*'] }],
@@ -121,3 +121,5 @@ export default /** @type {import('eslint').Linter.RulesRecord} */ ({
   'vitest/padding-around-expect-groups': 'off',
   'vitest/padding-around-test-blocks': 'off',
 });
+
+export default rules;