fix(examples): register and render the Settings dock in the vite/next hubs - #251
Closed
antfubot wants to merge 1 commit into
Closed
fix(examples): register and render the Settings dock in the vite/next hubs#251antfubot wants to merge 1 commit into
antfubot wants to merge 1 commit into
Conversation
… hubs hub-vite never registered the reserved `~settings` `~builtin` dock, so no Settings tab ever appeared at the standalone `/__devframes` mount - unlike hub-next, which already registered it for parity. hub-next's registration was itself inert: both hand-rolled clients treated every `~builtin` dock as needing no rail tab at all, so even the registered entry never rendered. Give `~builtin` its own tab in both clients, backed by a native Settings panel (per-dock visibility, using the shared `devframe:user-settings` state every viewer already reads) instead of routing it through the generic dock-renderer registry. 🤖 Generated with the help of an agent.
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
examples/hub-vitenever registered the reserved~settings~builtindock, so no Settings tab ever appeared at the standalone/__devframesmount — unlikeexamples/hub-next, which already registered it for parity with the hub-example-parity mandate in AGENTS.md.That registration in
hub-nextwas itself inert: both hand-rolled reference clients (examples/hub-vite's vanilla shell andexamples/hub-next's React shell) treated every~builtindock as needing no rail tab at all — lumped in withaction/launcher/group, which genuinely have no panel of their own. So evenhub-next's registered~settingsentry never rendered.This PR:
~settingsinhub-vite'sconfigure(), mirroringhub-next.~builtindocks their own tab in both clients (split out of the "no tab" type set), rendered through a native Settings panel per the documentedbuild-your-own-hub-uicontract instead of the generic dock-renderer registry.devframe:user-settingsstate (docksHidden) every viewer already reads — wiring up a capability the hub client types exposed but neither reference host previously exercised.Verified:
pnpm lint,pnpm typecheck,pnpm build, andpnpm test(includinghub-next's existing~settingsregistration assertion) all pass; manually confirmed over the wire protocol that a livehub-vitedev server registers~settingsindevframe:docksand that togglingdevframe:user-settings.docksHiddenround-trips correctly.🤖 Generated with the help of an agent.