Skip to content

rules_elixir: drop windows_ex_unit_test.patch after the upstream .bat PR merges #7087

Open

Description

@TrapsterDK

Blocked on: bazelverse/rules_elixir#5 (bazelverse/rules_elixir#5) merging.

Blocked until the bazelverse/rules_elixir PR with the Windows ex_unit_test .bat branch (material in #6547) merges and RULES_ELIXIR_COMMIT can point at it.

Where

  • patches/rules_elixir/windows_ex_unit_test.patch, patches/rules_elixir/BUILD.bazel
  • elixir/toolchain/repos.bzl:200 (patch list in pinned_archive(name = "rules_elixir"))
  • elixir/toolchain/pins.bzl:20-24 (RULES_ELIXIR_COMMIT, RULES_ELIXIR_SHA256, RULES_ELIXIR_URL)

Fix

  1. Bump the three RULES_ELIXIR_* pins to the upstream commit that holds the merged .bat branch.
  2. The upstream branch resolves OTP and Elixir from erlang_home/elixir_home; the dx copy uses the relocatable tree (relocatable_tree.patch, rules_elixir: upstream the relocatable tree patch after rules_erlang#18 lands #6940). If the relocatable tree has landed upstream too, delete windows_ex_unit_test.patch. If not, cut the patch down to the hunk that switches the .bat to the tree paths.
  3. Drop the label from repos.bzl and the file from patches/rules_elixir/BUILD.bazel if it is deleted.
  4. Run tools/dx test //elixir/... on Linux and the evidence workflow with scope=//elixir/tests/runtime:probe_test (plus the elixir-app fixture tests) on ["windows_x86_64","windows_arm64"]. Paste the run IDs in the PR.

Related: #6547, #6940, #3744.

Activity

  1. added
    P2Improve and finish existing features
    blockedWaiting on upstream or a design decision
    model:sonnetAgent lane: scoped change with stated design, Sonnet
    on Nov 5, 2026
  2. github-actions commented on Nov 5, 2026

    @github-actions

    Unblocked: #6547, #2, #3, #4 closed

  3. TrapsterDK commented on Nov 5, 2026

    @TrapsterDK
    CollaboratorAuthor

    Still blocked: bazelverse/rules_elixir has no PR carrying the Windows ex_unit_test .bat branch (open: #2, #3, #4; none merged). Needs the owner to open it from the #6547 material.

  4. TrapsterDK commented on Nov 6, 2026

    @TrapsterDK
    CollaboratorAuthor

    Opened the upstream PR from the #6547 material: bazelverse/rules_elixir#5 (upstream has issues disabled, so no issue). Still blocked until it merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Improve and finish existing featuresblockedWaiting on upstream or a design decisionmodel:sonnetAgent lane: scoped change with stated design, Sonnet

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions