Skip to content

release: Windows matrix runtime names the runtime targets, not the DLLs the cell zip ships #8571

Closed

Description

@TrapsterDK

Found in evidence run 42221586283 (task=test, windows_x86_64 and windows_arm64) for #8467. //deploy/release:release_host_cell_test host_cell_ships_exactly_its_members fails on both Windows cells: the archive lists the CRT DLLs, while the cell runtime lists msvc_vcruntime and windows_ucrt. #8467 does not change this.

Where

  • deploy/release/matrix.bzl:24 declares runtime as the labels //cc/toolchains:msvc_vcruntime and //cc/toolchains:windows_ucrt.
  • deploy/release/matrix.bzl:67 writes Label(runtime).name into the matrix JSON, which gives target names, not file names.
  • deploy/release/src/cell.rs:119 checks those names as top-level archive members.
  • deploy/release/host_cell_test.rs:29 compares them with the archive listing.

Fix

Write the basenames of the DLLs that each runtime target provides into the matrix JSON runtime field. Either keep a fixed map next to _cell in matrix.bzl, or get the names from the <cell>_inventory_runtimes output. Leave the label list as the build input. Update deploy/release/matrix_tests.bzl (matrix_unit) and the cell.rs parse tests to expect the DLL names. Check that release_cell.sh and the launcher pin parser (cli/adopt/src/launcher.rs) still accept the new names. Show it with evidence task=test scope=//deploy/release:release_host_cell_test flags=--config=dx_release on windows_x86_64 and windows_arm64.

Activity

  1. added
    P2Improve and finish existing features
    model:sonnetAgent lane: scoped change with stated design, Sonnet
    on Nov 6, 2026
  2. TrapsterDK commented on Nov 6, 2026

    @TrapsterDK
    CollaboratorAuthor

    Evidence run 42259473091 passed release_host_cell_test on windows_x86_64 and windows_arm64; PR 8670 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Improve and finish existing featuresmodel:sonnetAgent lane: scoped change with stated design, Sonnet

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions