Repository navigation
msix, apple macos, appimage, android, cuda, swift: platform labels (part of #9535) - #9709
TrapsterDK wants to merge 7 commits into
Conversation
|
Round 2 evidence: msix sign_test fix (sign_test.ps1 counted an unrolled empty array) on windows: run 42596275145. Apple macos link failure ('undefined symbol: main' in demo_bundle_bin) baseline on main for the same scope: run 42596278257. Round 1 runs: 42595799578 (apple, failed), 42595803403 (appimage, passed), 42595839634 (msix, failed on sign_test). |
|
Evidence notes: apple macos run 42596278257 on main fails the same way (ld64.lld undefined symbol main on demo_bundle_bin, parts_bundle_bin, ledger_bundle_bin), so that failure predates this PR. msix windows run 42596275145 failed on runner setup (Output base d:_bazel could not be created); re-dispatched as 42596552553 for @rules_dx_msix//tests:sign_test. iOS conversion remains for #9535. |
|
Review: changes requested The
🤖 Generated with Claude Code |
9a486bd to
1fdac41
Compare
|
Fixed: (1) rebased onto fresh origin/main, dropped stale edf8a01, re-applied the change onto main's renamed msix_package/appimage_package/validate.bzl layout; (2) msix sign_test re-dispatched on windows_x86_64: run 42602353303, and no other unwrapped Get-StoreCertificate uses exist (only the definition at line 73); (3) swift: Linux analysis of //swift/... and //appimage/... resolves with the always-on private _swift_extra_toolchains (Apple cc toolchains are macOS-exec-only, so Linux resolution is unchanged and macOS keeps priority); transition tests pass; (4) one platform_transition exported from libs/starlark/platform.bzl, used by appimage and msix; (5) apple README states platform only feeds selection/check, not the build platform; (6) msix README bullet rewrapped. Tests: libs/starlark, swift/platforms, msix tests, apple macos tests pass; appimage:metadata would not build locally (rust libz-sys remote-blob error, infra). |
|
Review: changes requested Earlier findings: 1 (rebase) and 4 (single exported New blocking findings:
Minor: 🤖 Generated with Claude Code |
1fdac41 to
86e9f7c
Compare
|
Fixed: (1) cuda fixtures (families/cuda/tests/fixtures/executable/BUILD.bazel, tools/testing/starters/fixtures/cuda/BUILD.bazel.fixture) moved to cuda_archs; repo-wide grep found no other callers; bazel query @rules_dx_cuda//... loads. (2) Rebased on fresh main. MODULE.bazel.lock regenerated with Bazel (fetch of @msvc_runtime with the repo's EULA env) and is unchanged from main on Linux; the stale msvc_runtime usage digest can only be re-evaluated on a Windows host, so msix sign_test re-dispatched: run 42603117737. (3) apple README line rewrapped, and now notes that an x86_64 macOS target platform fails with 'arch x86_64 is outside macos' where the app used to default to arm64. |
86e9f7c to
2a3f105
Compare
|
Fixed: run 42603117737 reached the test and sign_test failed at sign_test.ps1:88 ( |
|
Review: changes requested Earlier findings: the cuda callers are fixed. The repo-wide check at head 2a3f105 finds
🤖 Generated with Claude Code |
…d cuda_archs (part of #9535) msix, appimage and apple_macos_app take one optional platform label read through the shared probe; single_platform_error replaces platform_arch. rust_android_apk and android_check take platform labels. cuda macros rename platforms to cuda_archs, including the gazelle directive. swift wrappers take platforms and keep the extra toolchains private. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B
…9535) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B
…t of #9535) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B
…test edits covered by #9764; apple README wrap (part of #9535) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B
|
Fixed: (1) rust-android starter fixture BUILD.bazel.fixture now uses @rules_dx_android//platforms:arm64-v8a and :x86_64; grepped other fixtures, READMEs and BUILD files, no other string ABI callers (android fixtures and README already use labels). (2) Rebased onto fresh origin/main and dropped this PR's sign_test.ps1 edits (covered by #9761/#9764), so the file matches main; msix BUILD.bazel changes kept. (3) apple README platform paragraph separated from the srcs sentence and rewrapped. Tests: //tools/testing/starters:rust-android passes. |
2a3f105 to
02157c7
Compare
Part of #9535. Covers #9596 (msix, apple macos, appimage), #9597 (android, cuda) and #9598 (swift).
libs/starlark/platform.bzl: newsingle_platform_error.platform_archand its tests are deleted.platformlabel (default: current target platform), arch read through the shared probe; both build for that platform. msixplatforms/PLATFORM_VALUESremoved.apple_macos_app:platformsandarchreplaced byplatform; arch comes from the probe. Newfamilies/apple/platformswithmacos_arm64andmacos_x86_64.rust_android_apk,android_check:platformsare platform labels fromfamilies/android/platforms, mapped to ABIs; unknown labels fail with the ABI list.platformsrenamed tocuda_archsin all macros, checks, fixtures, README and the gazelle directive (dx_cuda_archs).swift_platform/swift_extra_toolchainsremoved;platformslabel list (default is the Linux platform for the target cpu) and a private_swift_extra_toolchains.Tests run locally on Linux: libs/starlark packaging_unit and platform_probe_analysis, gazelle cc_test and generation_test, apple macos failure tests, msix action/cell tests, cuda failure and cell tests, android bad_abi tests, swift transition_tests plus analysis of the ledger fixture. The msix
//:metadataand cuda//rules:wrapper_contract_teststargets cannot load in their module here (missingrules_rust_prost); they were not run. Nested-Bazel and consumer tests were not run.Not done, remains for #9535: iOS (
apple_ios_app,apple_framework,apple_xcframework) still usedevice/arm64styleplatformsandarch;oci_deployetc. were done in #9613. Evidence runs for macos_arm64 (apple), linux_x86_64 (appimage) and windows_x86_64 (msix) are dispatched: runs 42595799578, 42595803403, 42595839634.Latest fix: msix sign_test wraps Get-StoreCertificate results in @() at call sites (PowerShell unrolls single-element arrays, so .Count failed). Evidence for
@rules_dx_msix//tests:sign_teston windows_x86_64 (rebased branch): run 42602353303 (dispatched, pending). Apple macos failure (undefined symbol main) reproduces on main.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B
Evidence: msix sign_test windows_x86_64 re-dispatched as run 42603117737.
Latest evidence run (msix sign_test, windows_x86_64): 42603567863