Repository navigation
worktree: release frees slots with a missing lease record or directory - #9759
Open
TrapsterDK wants to merge 2 commits into
Open
TrapsterDK wants to merge 2 commits into
TrapsterDK wants to merge 2 commits into
Conversation
Collaborator
Author
|
Review: changes requested CI: the only analysis failure is the
🤖 Generated with Claude Code |
closes #9755) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B
…holder Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B
TrapsterDK
force-pushed
the
fix-worktree-release
branch
from
November 9, 2026 11:42
50fcc2c to
873da87
Compare
Collaborator
Author
|
Fixed: (1) gone_slot now runs worktree unlock before prune, with a test releasing a free slot whose directory is gone followed by ops::add reusing it; (2) orphan_record no longer claims the releaser as holder (holder unknown), so the holder check stays: a record-less slot needs a clean pushed tree or --force, with a test; (3) stated the gone-directory behaviour in the PR description. Rebased on origin/main; dx_worktree_test passes. 🤖 Generated with Claude Code |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9755
release now frees a slot whose checkout is registered but whose lease record is missing (the usual dirty/unpushed checks still run), and returns success when the slot directory is already gone instead of failing with 'cannot start git'. Tests added for both. Ran //cli/worktree:dx_worktree_test; no nested-Bazel or consumer tests run.
A slot whose directory is gone is dropped before the lease-holder check, so any session can drop another session's record; nothing is left to lose there. A missing record leaves the holder unknown, so releasing needs a clean, pushed checkout or --force.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Xut2hwESun1HL2eSVd1d5B