Skip to content

ci: add CI and a weekly OpenAPI auto-sync workflow - #153

Merged
devjiwonchoi merged 1 commit into
feat/client-ergonomicsfrom
feat/ci-autosync
Sep 9, 2026
Merged

devjiwonchoi merged 1 commit into
feat/client-ergonomicsfrom
feat/ci-autosync

Conversation

@devjiwonchoi

@devjiwonchoi devjiwonchoi commented Sep 9, 2026 •

Copy link
Copy Markdown
Owner

why?

The repo had no CI verifying it builds, and the spec was tracked manually. Both should be automated so equine stays green and in sync with Lichess without hand-maintenance.

how?

  • ci.yml: on push/PR, run install → typecheck → build → test (Node 22, matching hey-api's engine).
  • sync-openapi.yml: weekly, regenerate the client from upstream and open a PR when src/client changes.
  • The sync PR uses secrets.SYNC_TOKEN (falls back to GITHUB_TOKEN) so the generated PR triggers CI — add a SYNC_TOKEN PAT secret for that to work.

Top of the stack — stacked on #152.

@devjiwonchoi
devjiwonchoi added this pull request to stack #154 September 9, 2026 00:21
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-09T00:38:16.751774Z bcc5ee9 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2b9661dfbd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/sync-openapi.yml
@devjiwonchoi

Copy link
Copy Markdown
Owner Author

Fixed in bcc5ee9: the create-pull-request step now uses token: ${{ secrets.SYNC_TOKEN || secrets.GITHUB_TOKEN }} with a comment explaining that a PAT/App token is required for the sync PR to trigger CI (GITHUB_TOKEN-created PRs don't fire workflows). Falls back to GITHUB_TOKEN if the secret is unset.

@devjiwonchoi devjiwonchoi changed the title Add CI and a weekly OpenAPI auto-sync workflow ci: add CI and a weekly OpenAPI auto-sync workflow Sep 9, 2026
@devjiwonchoi

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: bcc5ee9b76

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devjiwonchoi

Copy link
Copy Markdown
Owner Author

The current head (bcc5ee9) already addresses this: the step uses token: ${{ secrets.SYNC_TOKEN || secrets.GITHUB_TOKEN }}. Setting a SYNC_TOKEN PAT makes the sync PR trigger CI as recommended. The GITHUB_TOKEN fallback is intentional so the workflow still opens the PR (just without CI) when the secret isn't configured, rather than failing — documented inline. Not changing further.

ci.yml runs install -> typecheck -> build -> test on push/PR.
sync-openapi.yml regenerates the client from upstream weekly and opens a
PR when src/client changes, so equine tracks Lichess with nothing
hand-maintained.
@devjiwonchoi
devjiwonchoi merged commit a4144ae into main Sep 9, 2026
2 checks passed
@devjiwonchoi
devjiwonchoi deleted the feat/ci-autosync branch September 9, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant