Repository navigation
chore: clear every compiler, lint and rustdoc warning; current Android dependencies - #85
Merged
Merged
Conversation
- Kotlin: two non-null assertions on values already known non-null, and the deprecated DriveFileMove icon (now its auto-mirrored version). - MissingPermission: a notification posted after the permission check may meet a permission revoked in between; that SecurityException is now caught instead of crashing. - InlinedApi: the sensitive-clipboard flag is set only where it exists (Android 13+), and the foreground service type is chosen per version (none before Android 10). - Backup: fullBackupContent="false" says to Android 11 and older what the data extraction rules say to 12+. - Cleanups: KTX edit/toUri/scale, the version catalog's own lint, the modifier as each composable's first optional parameter, a float state without boxing, PascalCase test composables, the v26-only mipmap folder merged (minSdk is 26), and imports in order. - The generated UniFFI bindings are excluded from lint: they cannot be fixed by hand, and their one finding (java.lang.ref.Cleaner below API 33) is guarded at run time with a fallback to JNA's cleaner. Co-Authored-By: Claude Code <noreply@anthropic.com>
Gradle 9.8.0 (wrapper checksum now pinned), AGP 9.4.1, core-ktx 1.19.1, kotlinx-serialization 1.11.0, Robolectric 4.17, Paparazzi 2.0.0-alpha05.1, markdown renderer 0.45.0, JNA 5.19.1 and Tink 1.23.0. JNA, Tink, CameraX, ZXing and the extended icons move from inline coordinates into gradle/libs.versions.toml, with the reasons for each. The markdown renderer now spaces paragraphs and list items slightly more; its parity golden is re-recorded (tables, task lists and code blocks render as before). Co-Authored-By: Claude Code <noreply@anthropic.com>
Public docs linked to private items (timeouts, caps, internal types); they are now named in code style rather than linked. The bridge's --workspace help wrote its default as a bracketed path, which rustdoc read as a broken link; it now says the default in words. Co-Authored-By: Claude Code <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before the 1.2.0 prerelease: the workspace now builds with zero warnings across Kotlin (debug, release, tests), Android lint, R8, cargo (release and
cargo doc), clippy and the agent host's build and typecheck.Android fixes that matter beyond the lint noise:
MissingPermission: a notification posted after the permission check could hit a permission revoked in between and crash. TheSecurityExceptionis now caught.InlinedApi: the sensitive-clipboard flag is set only on Android 13+. The foreground service type is chosen per version, and Android 8–9 now get no type rather than one they don't know.fullBackupContent="false"says to Android ≤ 11 what the data extraction rules say to 12+, so no backup on any version.java.lang.ref.Cleanerbelow API 33) is guarded at runtime with a fallback to JNA's cleaner.-v26mipmap folder; import order; two needless!!; a deprecated icon.Dependencies (lint
NewerVersionAvailableetc.):Rust: links from public docs to private items became plain code, and the bridge's
--workspacehelp states its default in words.Test plan
lintDebug: 0 issuescompileDebugKotlin compileReleaseKotlin compileDebugUnitTestKotlin: no warningsminifyReleaseWithR8: no warningstestDebugUnitTest verifyPaparazziDebugcargo clippy --workspace --all-targets -D warnings,cargo build --releaseandcargo doc: 0 warnings🤖 Generated with Claude Code