[gregorydemay]

Reports the automatic deposit flow of #272 in the metrics (watched addresses against the capacity, how long the earliest due scan has been waiting, scans by outcome, re-arms of dropped automatic deposits by outcome, dropped deposits by origin, collected fees) and on the dashboard (the fee parameter, the collected fees and a paginated table of the watched addresses).

🤖 Generated with Claude Code

[Copilot]

🟡 Changes recommended

The dashboard can display expired registrations as actively watched addresses.

1 open finding

• Filter expired registrations from the watched addresses table · New

What changed in this PR

Adds observability for the automatic deposit flow through metrics and the minter dashboard.

Changes:

• Adds watchlist, queued-deposit, age, and fee metrics.
• Adds fee metadata and a paginated watched-address table.
• Extends dashboard and integration tests.

File	Description
minter/​templates/​dashboard.html	Renders fees and watched addresses.
minter/​src/​metrics.rs	Exposes automatic-deposit metrics.
minter/​src/​dashboard/​tests.rs	Tests dashboard additions and pagination.
minter/​src/​dashboard/​mod.rs	Builds new dashboard data and pagination.
integration_tests/​tests/​tests.rs	Checks exported metrics.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

The pagination footer uses a five-column span for a six-column watched-address table, leaving it short of the “Next Scan At” column when there are more than 100 watched addresses.

1 open issue

• Fix pagination colspan for six-column watched-address table · New

2 resolved since last review

• Expose cumulative fees as a Prometheus counter
• Test metrics with a registered address and elapsed time

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

The watched-address table passes five columns to pagination despite having six, causing the pagination row to exclude “Next Scan At” when there are more than 100 addresses.

1 open issue

• Fix pagination colspan for six-column watched-address table

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

The watched-address pagination uses a colspan of five for a six-column table, leaving “Next Scan At” uncovered and misaligning controls when registrations exceed 100.

1 open issue

• Fix pagination colspan for six-column watched-address table

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Each metrics scrape now scans the permanently retained dropped-deposit history, causing its cost to grow with all historical failures instead of reading maintained per-origin totals.

1 open issue

• Avoid scanning all dropped deposits on each metrics scrape · New

1 resolved since last review

• Fix pagination colspan for six-column watched-address table

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues are reported for the automatic-deposit metrics and dashboard changes.

1 open issue

• Avoid scanning all dropped deposits on each metrics scrape

_{Review effort: Balanced}

[zeropath-ai]

✅ No security or compliance issues detected. Reviewed everything up to f3e4b38.

Security Overview

• 🔎 Scanned files: 14 changed file(s)
• 🔗 Scan Link: https://zeropath.com/app/repositories/58f1cdfe-c0c2-41c1-8d28-3d6efcaf3266?scanId=f190afcf-09ff-4ae6-bed1-16ee04c341a2&codeScanTypes=PrScan&tab=issues&detectionTypes=traditional,businessLogic,customRule,IAC,SECRETS,CICD,EOL,uncategorized

Detected Code Changes

Change Type

Relevant files

Enhancement

► integration_tests/tests/tests.rs     Modify imports and functions related to DepositSolArgs, DepositSolId, and sweep/finalize helpers; add sweep_deposit and finalize_and_credit_sweep helpers; adjust sweep/finalize flow and tests; update metric expectations and deposits handling ► minter/src/dashboard/mod.rs     Add Timestamp import and format_timestamp helper; expose watched_deposit_addresses_start in pagination; expose watched_deposit_addresses data in dashboard template; adjust DashboardTemplate to accept now: Timestamp and to include watched_deposit_addresses_table ► minter/src/dashboard/tests.rs     Update dashboard fixtures and tests to account for new watched deposit addresses table, timestamp formatting, and new fields; adapt imports and helper usage ► minter/src/main.rs     Use current Timestamp from ic time for dashboard rendering; pass now to DashboardTemplate::from_state ► minter/src/metrics.rs     Add metrics for watched_deposit_addresses, watched_deposit_address_capacity, oldest_due_deposit_address_scan_age_seconds, and collected_automatic_deposit_fees; adjust existing metric encoding to include per-origin dropped_deposits breakdown and additional RearmOutcome metrics ► minter/src/state/audit.rs     Record automatic deposit rearms and watchlist full events in log; increment corresponding metrics ► minter/src/state/watchlist/mod.rs     Expose capacity() and oldest_due_scan_at(now) methods; document live registrations and earliest due scan logic; extend live() to return WatchedAddress by expiry order ► minter/src/storage/mod.rs     Add automatic_deposit_rearms: BTreeMap<RearmOutcome, u64> to Metrics; initialize in Metrics; ensure storage supports RearmOutcome counting ► minter/Cargo.toml     Add time = workspace dependency for shared time utilities ► minter/templates/dashboard.html     Add UI rows for Automatic deposit fee and Collected automatic deposit fees; introduce Watched Deposit Addresses section with new columns (Account, Deposit Address, Valid Until, Scans, Last Scanned At, Next Scan At) and ensure linkage to deposit addresses ► minter/src/dashboard/mod.rs (template integration visuals)     Integrate new watched_deposit_addresses_table rendering into DashboardTemplate and template rendering logic ► minter/src/dashboard/tests.rs (additional tests)     Add tests for unconfigured automatic deposit fee display, collected automatic deposit fees display, watched deposit addresses display ordering, live address filtering, and pagination behavior ► minter/src/state/watchlist/tests.rs     Add tests asserting capacity() equals MAX_WATCHED_ADDRESSES and verify rearm behavior counts including WatchlistFull and Rearmed ► minter/src/state/audit.rs (additional logging context)     Emit records when rearming after dropped deposits and when watchlist is full upon rearm attempts