feat: Introduce icp:sync-plugin@0.2.0 - #719
Open
adamspofford-dfinity wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces sync-plugin ABI v0.2.0 while preserving compatibility with v0.1.x plugins through metadata-based runtime dispatch.
Changes:
- Adds parallel v1/v2 WIT bindings and ABI detection.
- Adds a legacy plugin fixture and compatibility test.
- Updates dependencies and documentation.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
docs/concepts/sync-plugins.md |
Documents interface versioning. |
crates/icp-sync-plugin/tests/fixtures/test-plugin-v1/src/lib.rs |
Implements legacy test plugin. |
crates/icp-sync-plugin/tests/fixtures/test-plugin-v1/Cargo.toml |
Configures legacy fixture. |
crates/icp-sync-plugin/tests/fixtures/test-plugin-v1/Cargo.lock |
Locks fixture dependencies. |
crates/icp-sync-plugin/tests/fixtures/test-plugin-v1/build.rs |
Tracks legacy WIT changes. |
crates/icp-sync-plugin/sync-plugin.wit |
Advances current ABI to v0.2.0. |
crates/icp-sync-plugin/sync-plugin-v1.wit |
Preserves the v0.1.0 contract. |
crates/icp-sync-plugin/src/runtime.rs |
Detects and dispatches ABI versions. |
crates/icp-sync-plugin/DESIGN.md |
Documents parallel ABI handling. |
crates/icp-sync-plugin/Cargo.toml |
Adds semver dependency. |
crates/icp-sync-plugin/build.rs |
Builds both test fixtures. |
Cargo.lock |
Records the dependency update. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
adamspofford-dfinity
force-pushed
the
spofford/plugin-multi-versioning
branch
from
August 24, 2026 16:43
35b3f24 to
db63f13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the sync plugin interface to 0.2.0. Both versions are supported side-by-side depending on what version the plugin imports (based on actual version metadata, not probing for e.g. field names).
Stack created with GitHub Stacks CLI • Give Feedback 💬