feat: Add key-value settings to plugin input - #722
Open
adamspofford-dfinity wants to merge 2 commits into
Open
Conversation
adamspofford-dfinity
force-pushed
the
spofford/plugin-kv
branch
from
August 20, 2026 16:38
61b849f to
27ee5d0
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds manifest-defined key-value fields to sync plugin inputs.
Changes:
- Parses scalar
fieldsvalues and passes them through the WIT runtime. - Preserves fields during project bundling.
- Adds tests, schemas, and documentation.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
docs/schemas/icp-yaml-schema.json |
Adds fields schema. |
docs/schemas/canister-yaml-schema.json |
Adds fields schema. |
docs/reference/configuration.md |
Documents configuration. |
docs/guides/writing-sync-plugins.md |
Documents plugin usage. |
docs/concepts/sync-plugins.md |
Describes runtime behavior. |
crates/icp/src/manifest/canister.rs |
Updates test expectations. |
crates/icp/src/manifest/adapter/plugin.rs |
Parses and validates fields. |
crates/icp/src/canister/sync/plugin.rs |
Forwards fields to runtime. |
crates/icp-sync-plugin/tests/fixtures/test-plugin/src/lib.rs |
Exercises field input. |
crates/icp-sync-plugin/sync-plugin.wit |
Extends plugin input contract. |
crates/icp-sync-plugin/src/runtime.rs |
Passes fields into plugins. |
crates/icp-sync-plugin/DESIGN.md |
Updates design documentation. |
crates/icp-cli/tests/bundle_tests.rs |
Tests bundle preservation. |
crates/icp-cli/src/operations/bundle.rs |
Preserves fields in bundles. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
adamspofford-dfinity
force-pushed
the
spofford/plugin-kv
branch
3 times, most recently
from
August 20, 2026 18:40
d76b109 to
7760935
Compare
adamspofford-dfinity
force-pushed
the
spofford/plugin-kv
branch
from
August 21, 2026 17:32
7760935 to
87f557c
Compare
adamspofford-dfinity
marked this pull request as ready for review
August 21, 2026 18:41
adamspofford-dfinity
force-pushed
the
spofford/plugin-kv
branch
from
August 21, 2026 21:14
87f557c to
ba841de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like:
Stack created with GitHub Stacks CLI • Give Feedback 💬