Skip to content

feat: Add key-value settings to plugin input - #722

Open
adamspofford-dfinity wants to merge 2 commits into
spofford/plugin-canister-accessfrom
spofford/plugin-kv
Open

feat: Add key-value settings to plugin input#722
adamspofford-dfinity wants to merge 2 commits into
spofford/plugin-canister-accessfrom
spofford/plugin-kv

Conversation

@adamspofford-dfinity

Copy link
Copy Markdown
Contributor

Looks like:

type: plugin
fields:
  a: b

Stack created with GitHub Stacks CLIGive Feedback 💬

Copilot AI balanced review requested due to automatic review settings August 20, 2026 16:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds manifest-defined key-value fields to sync plugin inputs.

Changes:

  • Parses scalar fields values and passes them through the WIT runtime.
  • Preserves fields during project bundling.
  • Adds tests, schemas, and documentation.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
docs/schemas/icp-yaml-schema.json Adds fields schema.
docs/schemas/canister-yaml-schema.json Adds fields schema.
docs/reference/configuration.md Documents configuration.
docs/guides/writing-sync-plugins.md Documents plugin usage.
docs/concepts/sync-plugins.md Describes runtime behavior.
crates/icp/src/manifest/canister.rs Updates test expectations.
crates/icp/src/manifest/adapter/plugin.rs Parses and validates fields.
crates/icp/src/canister/sync/plugin.rs Forwards fields to runtime.
crates/icp-sync-plugin/tests/fixtures/test-plugin/src/lib.rs Exercises field input.
crates/icp-sync-plugin/sync-plugin.wit Extends plugin input contract.
crates/icp-sync-plugin/src/runtime.rs Passes fields into plugins.
crates/icp-sync-plugin/DESIGN.md Updates design documentation.
crates/icp-cli/tests/bundle_tests.rs Tests bundle preservation.
crates/icp-cli/src/operations/bundle.rs Preserves fields in bundles.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread crates/icp-sync-plugin/sync-plugin.wit
@adamspofford-dfinity
adamspofford-dfinity force-pushed the spofford/plugin-kv branch 3 times, most recently from d76b109 to 7760935 Compare August 20, 2026 18:40
@adamspofford-dfinity
adamspofford-dfinity marked this pull request as ready for review August 21, 2026 18:41
@adamspofford-dfinity
adamspofford-dfinity requested a review from a team as a code owner August 21, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants