Repository navigation
ci: Build Linux arm64 release binary - #285
Merged
Merged
Conversation
Add a linux-arm64 entry to the release matrix, built natively on the ubuntu-22.04-arm runner so all default features (including Ledger) are kept. Also list the new asset in the README and fix the arm32 asset name there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
✅ No security or compliance issues detected. Reviewed everything up to 611d0a3. Security OverviewDetected Code Changes
|
There was a problem hiding this comment.
🟢 Approval recommended
The Linux arm64 release addition has no active review issues.
No open issues 🎉
What changed in this PR
Adds a native Linux arm64 release build, filling the gap in Quill’s Linux release assets while retaining default features, including Ledger support.
Changes:
- Builds
quill-linux-arm64onubuntu-22.04-arm, matching the existing Linux x86_64 build’s glibc baseline. - Documents the new asset, corrects the arm32 download filename, and adds an Unreleased changelog entry.
| File | Description |
|---|---|
| README.md | Lists the arm64 download and corrects the arm32 asset name. |
| CHANGELOG.md | Announces the Linux arm64 release binary under Unreleased. |
| .github/workflows/release.yml | Adds a native Linux arm64 release matrix entry. |
Review effort: Balanced
lwshang
approved these changes
Nov 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a Linux arm64 binary (
quill-linux-arm64) to the release assets. macOS arm64 was already built; Linux arm64 was the missing piece.linux-arm64entry in therelease.ymlmatrix, built natively on GitHub'subuntu-22.04-armrunner (free for public repos). Building natively avoidscrossand keeps all default features, including Ledger (the arm32 build has to drop it for armv6 compatibility).quill-arm_32→quill-linux-arm32, which is what the release actually uploads).Windows arm64 (
windows-11-arm) is not included; it would need the HID/vcpkg setup checked first.How Has This Been Tested?
actionlintpasses on the workflow.pull_request, so theRelease binary for linux-arm64job on this PR exercises the build (upload only happens on tags).Checklist
🤖 Generated with Claude Code