Skip to content

fix(ic-certification): fix docs.rs build and release 4.0.1 - #505

Merged
lwshang merged 2 commits into
mainfrom
fix/docs-rs-build
Oct 28, 2026
Merged

lwshang merged 2 commits into
mainfrom
fix/docs-rs-build

Conversation

@lwshang

@lwshang lwshang commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Problem

docs.rs hasn't been able to build docs for ic-certification since 3.0.3 (https://docs.rs/crate/ic-certification/latest). The build fails with:

error[E0557]: feature has been removed
 --> src/lib.rs:4:38
  |
4 | #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
  |                                      ^^^^^^^^^^^^ feature has been removed
  = note: removed in 1.92.0; see <https://github.com/rust-lang/rust/pull/138907>
  = note: merged into `doc_cfg`

Fix

  • Remove doc_auto_cfg and keep feature(doc_cfg). doc_cfg now includes the auto-cfg behaviour, so the feature-gate labels in the docs stay.
  • Release 4.0.1, bumping the same files the 4.0.0 release bumped (.cz.yaml, Cargo.toml, Cargo.lock, the JS package.json files) and adding a CHANGELOG entry. docs.rs builds each published version only once, so a new version is needed to get working docs.

Verified locally: RUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc -p ic-certification --all-features --no-deps succeeds.

After merging, tag the merge commit:

git tag 4.0.1
git push origin 4.0.1

🤖 Generated with Claude Code

lwshang and others added 2 commits October 28, 2026 09:48
doc_auto_cfg was removed in Rust 1.92 and merged into doc_cfg, so
rustdoc on nightly fails with E0557 and docs.rs has been unable to build
ic-certification docs since then.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lwshang
lwshang merged commit 2de9e04 into main Oct 28, 2026
9 checks passed
@lwshang
lwshang deleted the fix/docs-rs-build branch October 28, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants