Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integer starting coordinates silently truncate accepted continuous proposals while retaining their floating-point log probabilities. The stored positions and probabilities can then disagree:
The maximum discrepancy is about 2.52 on main and zero with this change. Promote integer or boolean starting coordinates to floating point before sampling. Existing floating-point types, including long double, keep their dtype. Regression cases compare signed/unsigned integer arrays and
Stateinputs with equivalent float starts using stretch and Gaussian moves. This supports continuous sampling from integer-valued starting positions; it does not add integer-valued proposals.Validation on Linux/Python 3.14.7: all 142 tests and repository-wide pre-commit hooks pass, including the existing long-double tests. For Bayesian regression on 107 NIST ultrasonic calibration measurements, all 108 signed/unsigned integer-start and
Stateconfigurations now match their float-start chains exactly. The floating controls are unchanged; an independently derived Gaussian posterior checks every stored log probability. Other platforms were not run locally.