Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
blobs_dtypeis omitted, the first walker's blob currently determines the dtype for every walker. A placeholder returned with-np.infcan therefore truncate valid floating-point blobs to integers, or make the HDF backend fail on an object dtype.This infers the dtype from the blobs with non-rejected log probabilities, while preserving object-array support for heterogeneous placeholders. An explicit
blobs_dtyperemains enforced.The regressions cover integer, boolean and
Noneplaceholders with both backends, plus directcompute_log_prob()calls with array-valued blobs. The full local suite passes on NumPy 1.26 and 2.5.