Skip to content

More language and blackPanther OS - #16

Open
blackPantherOS wants to merge 2 commits into
dhabyx:masterfrom
blackPantherOS:master
Open

blackPantherOS wants to merge 2 commits into
dhabyx:masterfrom
blackPantherOS:master

Conversation

@blackPantherOS

@blackPantherOS blackPantherOS commented Apr 6, 2017

Copy link
Copy Markdown

Hi, I've add Hungarian and blackPanther OS as well. Please check the code

@KonstantinShtepa

Copy link
Copy Markdown
Collaborator

Hello!
Thank for you work! )
I have a few questions:

  1. Why there two .svg? Especially, why there distro-blackPanther.svg?
  2. Why do you change icon path?
  3. Why do you change horizontalAlignment to Text.AlignHRight in OsInfoItem.qml?
  4. Did you test changes? Does hungarian translations works well? Does logo in "Default logo" mode at your "blackPanther OS" show tux.svg or blackpanther.svg?

@blackPantherOS

Copy link
Copy Markdown
Author

Hi, I'm not have time to all tests, just I pushed quickly, sorry. Please double check my modifications because I don't remember that I changed the Aling maybe I think the icon path was wrong?

@KonstantinShtepa

KonstantinShtepa commented Apr 7, 2017

Copy link
Copy Markdown
Collaborator

Ok, I understand that you don't have much time, but there two things that you should check and confirm(because only you can do it):

  1. Is that translation is alright and it works
  2. Is that logo autodetection on your distro works fine(logo should change on defaultLogo settings to blackPanther).
    Autodetection works by parsing /etc/os-release and getting ID value. So if it isn't work then you should tell me what value has ID key in your /etc/os-release.

If you check and confirm these two things then I can fix your patch and merge result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants