Repository navigation
Convert Again, overwrite that can't delete the file, and Join's trim (2.0.0-beta.7) - #10
Merged
Merged
Conversation
… ends converting and joinRunning were cleared only when the run resolved; a run that threw left Restart Now asking about a conversion that wasn't running.
Once a card had converted, its format and Advanced Options could still be changed, but nothing would run them: Convert skips a Done card, and only a failed card offered Retry. A converted card now keeps the format and options that made its file, locked as a card in the run is, with Convert Again beside Show in Folder. Convert Again sends it back to Ready with the same format and options, unlocked, and Convert runs only it. The earlier file is left where it is: a run onto the same name meets File Already Exists, as any other does. The lock, the reset and the card's buttons move into display.js, where the suite can reach them. The bulk bar's format and Bulk Edit are disabled when every card they would apply to is locked, rather than taking a pick and changing nothing.
…'t delete it
Converting a file to its own format onto itself sent FFmpeg straight at its
own input, which it refuses ("cannot edit existing files in-place"). The
clean-up after a failed run then deleted the output path, which was the
original. Any overwrite whose run failed or was cancelled lost the old file
the same way.
A run onto something that already exists now writes name.dfc-partial.ext
beside it and renames it over the target only once FFmpeg exits cleanly.
Each clip's Trim button opens the span control under its row: the slider, the exact-time boxes, the first and last frames, and Shift for one frame at a time. The drag and keys (wireTrimHandles) and the frame painter (framePreviewer) are now shared with Advanced Options rather than copied.
WillTDA
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once a card had converted, its format and Advanced Options could still be changed, but nothing would run them: Convert skips a Done card, and only a failed card offered Retry.
name (1).ext).display.isLocked(),reopen()andcardActions(), tested intest/display.test.js. MANUAL-TESTING has a new "Convert Again" section (not yet run by hand).Also in this PR
name.dfc-partial.extbeside it and renames it over the target only once FFmpeg succeeds, so converting a file onto itself works. Tested intest/runner.test.js, and with real FFmpeg against the old and new runner.wireTrimHandles) and the frame painter (framePreviewer) are shared with Advanced Options, not copied.Built on #9 (
busy-flags-finally), which merges first.npm test206/206. Driven in the running app: lock, Convert Again, the prompt, Save as New; Join's drag, Shift-drag, Shift+arrow, frames, a refused time and an audio clip; Advanced Options' trim unchanged.