Repository navigation
Join's clip list scrolls while a join runs - #12
Merged
Merged
Conversation
The lock made the whole scrolling area inert, which took its scrollbar and mouse wheel with it, so a long list couldn't be looked through mid-join. Now the clips and Add More are inert and grey; the scroller stays live.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the lock added in #11: it made the whole scrolling area inert, which took its vertical scrollbar and mouse wheel with it, so with many clips the ones below the fold couldn't be looked at until the join ended.
Now the clips and Add More are inert and greyed, and the scroller around them stays live. The test holds the scroller itself to never being made inert.
Driven in the running app with 14 clips: with the lock on, the wheel and a click in the scrollbar's track both scroll, the clips stay locked, and everything comes back afterwards. A section is added to docs/MANUAL-TESTING.md.
Also bumps the version to 2.0.0-beta.9.