Repository navigation
Fix three card bugs, 2.0.0-beta.5 - #7
Merged
Merged
Conversation
…onverting card - Cancel no longer flickers under the pointer: a card's buttons are only rebuilt when they change, not on every progress tick. - The Last frame preview steps back when its seek lands after the video's last picture, as it does when the audio runs longer than the video. - A card in a running batch, queued or converting, locks its Advanced Options button, its image-count line and its format select. The dialog used to open and report settings applied that never took effect. 2.0.0-beta.5, with its manual testing section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three bugs found on beta.4. All three are in the app; electron-kit has no part in them, so the kit stays at 0.1.0-beta.3.
renderCardActionscleared and rebuilt the card's buttons on every progress tick, so the hovered Cancel was replaced many times a second. The buttons are now only rebuilt when the status or output changes.Version 2.0.0-beta.5.
npm test: 198 passing. A new section indocs/MANUAL-TESTING.mdcovers all three; it hasn't been run yet.