Skip to content

Fix three card bugs, 2.0.0-beta.5 - #7

Merged
WillTDA merged 1 commit into
2.0.0from
card-fixes
Oct 5, 2026
Merged

WillTDA merged 1 commit into
2.0.0from
card-fixes

Conversation

@WillTDA

@WillTDA WillTDA commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Three bugs found on beta.4. All three are in the app; electron-kit has no part in them, so the kit stays at 0.1.0-beta.3.

  • Cancel flickered under the pointer. renderCardActions cleared and rebuilt the card's buttons on every progress tick, so the hovered Cancel was replaced many times a second. The buttons are now only rebuilt when the status or output changes.
  • The Last frame box stayed empty. A container can run past its video's last frame when the audio is longer (the reported file's container ends at 3:10.334, its picture at 3:10.284). ffmpeg decodes nothing in that gap and exits cleanly, so no image came back. The preview handler now steps back 0.25s, 1s, then 5s until it finds a picture. A real decode failure still gives no preview.
  • Advanced Options opened and "applied" on a card being converted. Settings and format are sent when Convert is pressed, so the edits never took effect, but the toast said they had. Cards in the batch, queued as well as running, now lock their tune button, image-count line and format select until their result comes back. Apply also skips them and only counts the files it changed.

Version 2.0.0-beta.5. npm test: 198 passing. A new section in docs/MANUAL-TESTING.md covers all three; it hasn't been run yet.

…onverting card

- Cancel no longer flickers under the pointer: a card's buttons are only
  rebuilt when they change, not on every progress tick.
- The Last frame preview steps back when its seek lands after the video's
  last picture, as it does when the audio runs longer than the video.
- A card in a running batch, queued or converting, locks its Advanced
  Options button, its image-count line and its format select. The dialog
  used to open and report settings applied that never took effect.

2.0.0-beta.5, with its manual testing section.
@WillTDA
WillTDA merged commit e9a0b23 into 2.0.0 Oct 5, 2026
2 checks passed
@WillTDA
WillTDA deleted the card-fixes branch October 5, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant