Repository navigation
2.0.0-beta.6: the kit's config() and installer, on electron-kit 0.1.0-beta.8 - #8
Merged
Merged
Conversation
…ux, appId and busy
- electron-builder.cjs, from config(): package.json's build moves there, with the 22 types as fileTypes and
"Convert with Diamond File Converter" on files and folders as contextMenu. installer.nsh goes: the kit's
installer writes the same key, asks who it's for (upgrading an install for everyone in place), and asks for
each type and the right-click entry. On Linux, the .deb and .rpm put the app in Open With for each type.
- start({ appId }): Windows groups the window under its pinned icon and shows its notifications.
- mountShell({ busy }): Restart Now asks first while a conversion or a join runs.
- README's installation, the design-system note, and a beta.6 section in MANUAL-TESTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config().package.json'sbuildmoves there, with the 22 types asfileTypesand "Convert with Diamond File Converter" on files and folders ascontextMenu.installer.nshgoes.DiamondFileConverterkeyinstaller.nshdid, and the old version's uninstaller removes its own file associations during the update, so nothing shows twice..deband.rpmput the app in Open With for each type, and the dock shows its icon.start({ appId }): Windows groups the window under its pinned icon and shows its notifications.mountShell({ busy }): Restart Now asks first while a conversion or a join runs.198 tests pass. A trial Windows build made the asking installer (
oneClick=false,perMachine=false).