Conversation
馃 Changeset detectedLatest commit: 13f0242 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@mskec is attempting to deploy a commit to the diegomura Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
FontSource.load()keeps the first_load()promise in a cache. If that call fails, the rejected promise stays in the cache. Every laterload()call returns the same rejection. The font never loads again.This problem is if this happens in a long running container. One failed fetch then breaks each later render that uses the font.
Reproduction
Register a font. Make the first
fetchcall fail. Render two documents that use the font.The second render fails with the error from the first render. No second fetch occurs.
Fix
load()removes the cached promise when_load()fails, then re-throws the error. The cache keeps only a successful load.