Repository navigation
Add java.util.OptionalInt - #41
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a minimal, executable JBMC model for java.util.OptionalInt to support deterministic construction and basic accessors consistent with the JDK contract.
Changes:
- Introduces
java.util.OptionalIntwithempty(),of(int),isPresent(),isEmpty(), andgetAsInt()(throwingNoSuchElementExceptionwhen absent). - Adds an
orElse(int)convenience method (not mentioned in the PR description).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+7
| package java.util; | ||
|
|
||
| /** | ||
| * JBMC model of java.util.OptionalInt. | ||
| * A simple value container: either empty or holds an int. | ||
| */ | ||
| public final class OptionalInt { |
tautschnig
force-pushed
the
model-optionalint
branch
from
July 28, 2026 23:45
c564b63 to
5dd4167
Compare
peterschrammel
approved these changes
Oct 25, 2026
Without a model, JBMC treats OptionalInt as a stub class, so that the results of OptionalInt.of, isPresent, getAsInt etc. are nondeterministic. Like the other models in this library, this is the OpenJDK 8 source file, with changes marked "DIFFBLUE MODEL LIBRARY". The only change is the addition of isEmpty from JDK 11. The JDK implementation needs no other changes for JBMC: it has no loops, no native methods, and its empty instance is a final static field, which JBMC's --nondet-static does not make nondeterministic. Checked with JBMC on a program that asserts the documented behaviour of empty, of, isPresent, isEmpty, getAsInt, orElse, equals and hashCode: all assertions hold, and two false assertions are reported as failing, with and without --symex-driven-lazy-loading and --nondet-static. Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
tautschnig
force-pushed
the
model-optionalint
branch
from
November 4, 2026 10:40
5dd4167 to
9274a63
Compare
tautschnig
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without a model, JBMC treats OptionalInt as a stub class, so that the
results of OptionalInt.of, isPresent, getAsInt etc. are
nondeterministic.
Like the other models in this library, this is the OpenJDK 8 source
file, with changes marked "DIFFBLUE MODEL LIBRARY". The only change is
the addition of isEmpty from JDK 11. The JDK implementation needs no
other changes for JBMC: it has no loops, no native methods, and its
empty instance is a final static field, which JBMC's --nondet-static
does not make nondeterministic.
Checked with JBMC on a program that asserts the documented behaviour of
empty, of, isPresent, isEmpty, getAsInt, orElse, equals and hashCode:
all assertions hold, and two false assertions are reported as failing,
with and without --symex-driven-lazy-loading and --nondet-static.