add arch option to scons build command - #33
Merged
Conversation
scons arch=native lib # local scons arch=x86-64-v3 lib # portable AVX2 deploy scons lib # default: no -march (unchanged behaviour) or via $ export OBJCRYST_ARCH=x86-64-v3
clemisch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows specifying which
archto use for compilation.nativemight be optiomal for a local build,x86-64-v3should be portable for non-ancient machines. Default is not to specify anything.It's either a scons command
scons arch=...or it's read fromOBJCRYST_ARCHenv variable, which has been handy for me if I build pyobjcryst right after (which will get the same PR).For pyobjcryst this feature might get defered for the same reasons as diffpy/pyobjcryst#104 but I'll still open it ;-)