makeNdArray: return pyarray directly instead of bp::incref - #108
Merged
Conversation
Contributor
Author
|
PS: I know this number of incoming contributions might look a bit... suspicious these days. I have been using them for months in my forks; it's just that I finally contribute them upstream now all at once ;-) E.g. this one is here: clemisch@0786ab5 |
Collaborator
|
Can you add the corresponding news item ? |
Contributor
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend helper
makeNdArrayunnecessarily usesbp::increfon returned array. This increases its refcount from 1 to 2 and effectively leads to a memory leak.PyArray_SimpleNew()already returns a new reference with refcount 1 so theincrefis unnecessary.